@@ -557,18 +557,16 @@ extern "C" {
557557#define I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC fourcc_mod_code(INTEL, 8)
558558
559559/*
560+ * Intel Tile 4 layout
560561 * TODO: Remove the non-PRELIM version of DG2 CCS modifiers in the 9-11 ID range
561562 * Backport the upstream ADL-P CCS modifiers using the 9-11 ID range.
563+ * This is a tiled layout using 4KB tiles in a row-major layout. It has the same
564+ * shape as Tile Y at two granularities: 4KB (128B x 32) and 64B (16B x 4). It
565+ * only differs from Tile Y at the 256B granularity in between. At this
566+ * granularity, Tile Y has a shape of 16B x 32 rows, but this tiling has a shape
567+ * of 64B x 8 rows.
562568 */
563-
564- /*
565- * Intel F-tiling(aka Tile4) layout
566- *
567- * This is a tiled layout using 4Kb tiles in row-major layout.
568- * Within the tile pixels are laid out in 64 byte units / sub-tiles in OWORD
569- * (16 bytes) chunks column-major..
570- */
571- #define I915_FORMAT_MOD_F_TILED fourcc_mod_code(INTEL, 12)
569+ #define I915_FORMAT_MOD_4_TILED fourcc_mod_code(INTEL, 9)
572570
573571/*
574572 * Intel color control surfaces (CCS) for DG2 render compression.
@@ -579,8 +577,9 @@ extern "C" {
579577 * be associated with buffers of this type. Render compression uses 128 byte
580578 * compression blocks.
581579 */
582- #define I915_FORMAT_MOD_F_TILED_DG2_RC_CCS fourcc_mod_code(INTEL, 9)
583- #define PRELIM_I915_FORMAT_MOD_F_TILED_DG2_RC_CCS intel_prelim_fourcc_mod_code(13)
580+ #define I915_FORMAT_MOD_4_TILED_DG2_RC_CCS fourcc_mod_code(INTEL, 10)
581+ #define PRELIM_I915_FORMAT_MOD_4_TILED_DG2_RC_CCS intel_prelim_fourcc_mod_code(13)
582+ #define PRELIM_I915_FORMAT_MOD_F_TILED_DG2_RC_CCS PRELIM_I915_FORMAT_MOD_4_TILED_DG2_RC_CCS
584583
585584/*
586585 * Intel color control surfaces (CCS) for DG2 media compression.
@@ -591,17 +590,19 @@ extern "C" {
591590 * be associated with buffers of this type. Media compression uses 256 byte
592591 * compression blocks.
593592 */
594- #define I915_FORMAT_MOD_F_TILED_DG2_MC_CCS fourcc_mod_code(INTEL, 10)
595- #define PRELIM_I915_FORMAT_MOD_F_TILED_DG2_MC_CCS intel_prelim_fourcc_mod_code(14)
593+ #define I915_FORMAT_MOD_4_TILED_DG2_MC_CCS fourcc_mod_code(INTEL, 11)
594+ #define PRELIM_I915_FORMAT_MOD_4_TILED_DG2_MC_CCS intel_prelim_fourcc_mod_code(14)
595+ #define PRELIM_I915_FORMAT_MOD_F_TILED_DG2_MC_CCS PRELIM_I915_FORMAT_MOD_4_TILED_DG2_MC_CCS
596596
597597/*
598598 * Intel color control surfaces (CCS) for DG2 clear color render compression.
599599 *
600600 * DG2 uses a unified compression format for clear color render compression.
601601 * The general layout is a tiled layout using 4Kb tiles i.e. Tile4 layout.
602602 */
603- #define I915_FORMAT_MOD_F_TILED_DG2_RC_CCS_CC fourcc_mod_code(INTEL, 11)
604- #define PRELIM_I915_FORMAT_MOD_F_TILED_DG2_RC_CCS_CC intel_prelim_fourcc_mod_code(15)
603+ #define I915_FORMAT_MOD_4_TILED_DG2_RC_CCS_CC fourcc_mod_code(INTEL, 12)
604+ #define PRELIM_I915_FORMAT_MOD_4_TILED_DG2_RC_CCS_CC intel_prelim_fourcc_mod_code(15)
605+ #define PRELIM_I915_FORMAT_MOD_F_TILED_DG2_RC_CCS_CC PRELIM_I915_FORMAT_MOD_4_TILED_DG2_RC_CCS_CC
605606
606607/*
607608 * Tiled, NV12MT, grouped in 64 (pixels) x 32 (lines) -sized macroblocks
0 commit comments