Revert "Improve private allocation storage."

This reverts commit be3ca80.

Signed-off-by: Compute-Runtime-Validation <[email protected]>

Author: Compute-Runtime-Validation

opencl/test/unit_test/memory_manager/storage_info_tests.cpp

@@ -108,19 +108,20 @@ TEST_F(MultiDeviceStorageInfoTest, givenDisabledFlagForMultiTileIsaPlacementWhen
     }
 }
 
-TEST_F(MultiDeviceStorageInfoTest, whenCreatingStorageInfoForPrivateSurfaceThenSingleMemoryBanksAreOnAndPageTableClonningIsNotRequired) {
+TEST_F(MultiDeviceStorageInfoTest, whenCreatingStorageInfoForPrivateSurfaceThenAllMemoryBanksAreOnAndPageTableClonningIsNotRequired) {
     AllocationProperties properties{mockRootDeviceIndex, false, 0u, GraphicsAllocation::AllocationType::PRIVATE_SURFACE, false, false, singleTileMask};
     auto storageInfo = memoryManager->createStorageInfoFromProperties(properties);
-    EXPECT_TRUE(storageInfo.cloningOfPageTables);
-    EXPECT_EQ(singleTileMask, storageInfo.memoryBanks);
-    EXPECT_EQ(singleTileMask, storageInfo.pageTablesVisibility);
-    EXPECT_FALSE(storageInfo.tileInstanced);
-    EXPECT_EQ(1u, storageInfo.getNumBanks());
+    EXPECT_FALSE(storageInfo.cloningOfPageTables);
+    EXPECT_EQ(allTilesMask, storageInfo.memoryBanks);
+    EXPECT_EQ(allTilesMask, storageInfo.pageTablesVisibility);
+    EXPECT_TRUE(storageInfo.tileInstanced);
+    EXPECT_EQ(numDevices, storageInfo.getNumBanks());
 
     properties.flags.multiOsContextCapable = true;
     auto storageInfo2 = memoryManager->createStorageInfoFromProperties(properties);
     EXPECT_FALSE(storageInfo2.cloningOfPageTables);
     EXPECT_EQ(allTilesMask, storageInfo2.memoryBanks);
+    EXPECT_EQ(allTilesMask, storageInfo.pageTablesVisibility);
     EXPECT_TRUE(storageInfo2.tileInstanced);
     EXPECT_EQ(numDevices, storageInfo2.getNumBanks());
 }

shared/source/memory_manager/definitions/storage_info.cpp

@@ -66,6 +66,7 @@ StorageInfo MemoryManager::createStorageInfoFromProperties(const AllocationPrope
         }
     } break;
     case GraphicsAllocation::AllocationType::DEBUG_CONTEXT_SAVE_AREA:
+    case GraphicsAllocation::AllocationType::PRIVATE_SURFACE:
     case GraphicsAllocation::AllocationType::WORK_PARTITION_SURFACE:
         storageInfo.cloningOfPageTables = false;
         storageInfo.memoryBanks = allTilesValue;
@@ -81,7 +82,6 @@ StorageInfo MemoryManager::createStorageInfoFromProperties(const AllocationPrope
         }
         break;
     case GraphicsAllocation::AllocationType::SCRATCH_SURFACE:
-    case GraphicsAllocation::AllocationType::PRIVATE_SURFACE:
     case GraphicsAllocation::AllocationType::PREEMPTION:
         if (properties.flags.multiOsContextCapable) {
             storageInfo.cloningOfPageTables = false;