Skip to content

Commit fa285af

Browse files
Prepare unit test helper to move to share code
Related-To: NEO-5161 Signed-off-by: Milczarek, Slawomir <[email protected]>
1 parent cd8e30a commit fa285af

File tree

7 files changed

+12
-10
lines changed

7 files changed

+12
-10
lines changed

opencl/test/unit_test/command_queue/enqueue_copy_buffer_tests.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -202,8 +202,9 @@ HWTEST_F(EnqueueCopyBufferTest, WhenCopyingBufferThenIndirectDataGetsAdded) {
202202
EXPECT_NE(0u, multiDispatchInfo.size());
203203

204204
auto kernel = multiDispatchInfo.begin()->getKernel();
205+
auto kernelDescriptor = &kernel->getKernelInfo().kernelDescriptor;
205206

206-
EXPECT_TRUE(UnitTestHelper<FamilyType>::evaluateDshUsage(dshBefore, pDSH->getUsed(), kernel, rootDeviceIndex));
207+
EXPECT_TRUE(UnitTestHelper<FamilyType>::evaluateDshUsage(dshBefore, pDSH->getUsed(), kernelDescriptor, rootDeviceIndex));
207208
EXPECT_NE(iohBefore, pIOH->getUsed());
208209
if (kernel->requiresSshForBuffers()) {
209210
EXPECT_NE(sshBefore, pSSH->getUsed());

opencl/test/unit_test/command_queue/enqueue_fill_buffer_tests.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,8 +115,9 @@ HWTEST_F(EnqueueFillBufferCmdTests, WhenFillingBufferThenIndirectDataGetsAdded)
115115
EXPECT_NE(0u, multiDispatchInfo.size());
116116

117117
auto kernel = multiDispatchInfo.begin()->getKernel();
118+
auto kernelDescriptor = &kernel->getKernelInfo().kernelDescriptor;
118119

119-
EXPECT_TRUE(UnitTestHelper<FamilyType>::evaluateDshUsage(dshBefore, pDSH->getUsed(), kernel, rootDeviceIndex));
120+
EXPECT_TRUE(UnitTestHelper<FamilyType>::evaluateDshUsage(dshBefore, pDSH->getUsed(), kernelDescriptor, rootDeviceIndex));
120121
EXPECT_NE(iohBefore, pIOH->getUsed());
121122
if (kernel->requiresSshForBuffers()) {
122123
EXPECT_NE(sshBefore, pSSH->getUsed());

opencl/test/unit_test/command_queue/enqueue_kernel_1_tests.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -431,7 +431,7 @@ HWTEST_F(EnqueueKernelTest, WhenEnqueingKernelThenIndirectDataIsAdded) {
431431
auto sshBefore = pSSH->getUsed();
432432

433433
callOneWorkItemNDRKernel();
434-
EXPECT_TRUE(UnitTestHelper<FamilyType>::evaluateDshUsage(dshBefore, pDSH->getUsed(), pKernel, rootDeviceIndex));
434+
EXPECT_TRUE(UnitTestHelper<FamilyType>::evaluateDshUsage(dshBefore, pDSH->getUsed(), &pKernel->getKernelInfo().kernelDescriptor, rootDeviceIndex));
435435
EXPECT_NE(iohBefore, pIOH->getUsed());
436436
if (pKernel->requiresSshForBuffers() || (pKernel->getKernelInfo().patchInfo.imageMemObjKernelArgs.size() > 0)) {
437437
EXPECT_NE(sshBefore, pSSH->getUsed());

opencl/test/unit_test/command_queue/enqueue_read_buffer_tests.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,8 +156,9 @@ HWTEST_F(EnqueueReadBufferTypeTest, addsIndirectData) {
156156
EXPECT_NE(0u, multiDispatchInfo.size());
157157

158158
auto kernel = multiDispatchInfo.begin()->getKernel();
159+
auto kernelDescriptor = &kernel->getKernelInfo().kernelDescriptor;
159160

160-
EXPECT_TRUE(UnitTestHelper<FamilyType>::evaluateDshUsage(dshBefore, pDSH->getUsed(), kernel, rootDeviceIndex));
161+
EXPECT_TRUE(UnitTestHelper<FamilyType>::evaluateDshUsage(dshBefore, pDSH->getUsed(), kernelDescriptor, rootDeviceIndex));
161162
EXPECT_NE(iohBefore, pIOH->getUsed());
162163
if (kernel->requiresSshForBuffers()) {
163164
EXPECT_NE(sshBefore, pSSH->getUsed());

opencl/test/unit_test/command_queue/enqueue_write_buffer_tests.cpp

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -154,8 +154,9 @@ HWTEST_F(EnqueueWriteBufferTypeTest, WhenWritingBufferThenIndirectDataIsAdded) {
154154
EXPECT_NE(0u, multiDispatchInfo.size());
155155

156156
auto kernel = multiDispatchInfo.begin()->getKernel();
157+
auto kernelDescriptor = &kernel->getKernelInfo().kernelDescriptor;
157158

158-
EXPECT_TRUE(UnitTestHelper<FamilyType>::evaluateDshUsage(dshBefore, pDSH->getUsed(), kernel, rootDeviceIndex));
159+
EXPECT_TRUE(UnitTestHelper<FamilyType>::evaluateDshUsage(dshBefore, pDSH->getUsed(), kernelDescriptor, rootDeviceIndex));
159160
EXPECT_NE(iohBefore, pIOH->getUsed());
160161
if (kernel->requiresSshForBuffers()) {
161162
EXPECT_NE(sshBefore, pSSH->getUsed());

opencl/test/unit_test/helpers/unit_test_helper.h

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,20 +8,18 @@
88
#pragma once
99
#include "shared/source/helpers/aux_translation.h"
1010

11-
#include "opencl/source/helpers/properties_helper.h"
12-
1311
#include "hw_cmds.h"
1412

1513
namespace NEO {
1614

17-
class Kernel;
15+
struct KernelDescriptor;
1816
struct HardwareInfo;
1917

2018
template <typename GfxFamily>
2119
struct UnitTestHelper {
2220
static bool isL3ConfigProgrammable();
2321

24-
static bool evaluateDshUsage(size_t sizeBeforeEnqueue, size_t sizeAfterEnqueue, Kernel *kernel, uint32_t rootDeviceIndex);
22+
static bool evaluateDshUsage(size_t sizeBeforeEnqueue, size_t sizeAfterEnqueue, const KernelDescriptor *kernelDescriptor, uint32_t rootDeviceIndex);
2523

2624
static bool isPageTableManagerSupported(const HardwareInfo &hwInfo);
2725

opencl/test/unit_test/helpers/unit_test_helper.inl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ bool UnitTestHelper<GfxFamily>::isL3ConfigProgrammable() {
1313
};
1414

1515
template <typename GfxFamily>
16-
bool UnitTestHelper<GfxFamily>::evaluateDshUsage(size_t sizeBeforeEnqueue, size_t sizeAfterEnqueue, Kernel *kernel, uint32_t rootDeviceIndex) {
16+
bool UnitTestHelper<GfxFamily>::evaluateDshUsage(size_t sizeBeforeEnqueue, size_t sizeAfterEnqueue, const KernelDescriptor *kernelDescriptor, uint32_t rootDeviceIndex) {
1717
if (sizeBeforeEnqueue != sizeAfterEnqueue) {
1818
return true;
1919
}

0 commit comments

Comments
 (0)