fix: enable nvd_api tests and add modEndDate param (#1427)

* fix: enable nvd_api tests and add modEndDate param
* enable nvd_api tests in ci
* fixes #1422

Author: imsahil007

.github/workflows/pythonapp.yml

@@ -114,7 +114,6 @@ jobs:
           --ignore=test/test_cli.py
           --ignore=test/test_cvedb.py
           --ignore=test/test_requirements.py
-          --ignore=test/test_nvd_api.py
       - name: Run synchronous tests
         run: >
           pytest -v
@@ -183,7 +182,6 @@ jobs:
           --ignore=test/test_cli.py
           --ignore=test/test_cvedb.py
           --ignore=test/test_requirements.py
-          --ignore=test/test_nvd_api.py
       - name: Run synchronous tests
         run: >
           pytest -v --cov --cov-append --cov-report=xml
@@ -255,7 +253,6 @@ jobs:
           --ignore=test/test_cvedb.py
           --ignore=test/test_requirements.py
           --ignore=test/test_helper_script.py
-          --ignore=test/test_nvd_api.py
       - name: Run synchronous tests
         run: >
           pytest -v

cve_bin_tool/nvd_api.py

@@ -102,6 +102,7 @@ async def get_nvd_params(
             self.params["modStartDate"] = self.convert_date_to_nvd_date(
                 time_of_last_update - timedelta(minutes=2)
             )
+            self.params["modEndDate"] = self.convert_date_to_nvd_date(datetime.now())
             self.logger.info(
                 f'Fetching updated CVE entries after {self.params["modStartDate"]}'
             )

test/test_nvd_api.py

@@ -21,7 +21,6 @@ def teardown_class(cls):
         shutil.rmtree(cls.outdir)
 
     @pytest.mark.asyncio
-    @pytest.mark.skip(reason="Disabled due to timeouts")
     async def test_get_nvd_params(self):
         """Test NVD for a future date. It should be empty"""
         nvd_api = NVD_API()
@@ -32,7 +31,6 @@ async def test_get_nvd_params(self):
         assert nvd_api.total_results == 0 and nvd_api.all_cve_entries == []
 
     @pytest.mark.asyncio
-    @pytest.mark.skip(reason="Disabled due to timeouts")
     async def test_total_results_count(self):
         """Total results should be greater than or equal to the current fetched cves"""
         nvd_api = NVD_API()
@@ -43,7 +41,6 @@ async def test_total_results_count(self):
         assert len(nvd_api.all_cve_entries) >= nvd_api.total_results
 
     @pytest.mark.asyncio
-    @pytest.mark.skip(reason="Disabled due to timeouts")
     async def test_nvd_incremental_update(self):
         """Test to check whether we are able to fetch and save the nvd entries using time_of_last_update"""
         nvd_api = NVD_API(incremental_update=True)