fix: icu checker (#1208)

* fix: icu checker
* fix: black and isort
fixes #1007

Author: peb-peb

cve_bin_tool/checkers/icu.py

@@ -12,11 +12,16 @@
 
 
 class IcuChecker(Checker):
-    CONTAINS_PATTERNS = []
-    FILENAME_PATTERNS = [r"icu", r"international_components_for_unicode"]
+    CONTAINS_PATTERNS = [
+        r"-i or --icudatadir       directory for locating any needed intermediate data files,",
+        r"-j or --write-java       write a Java ListResourceBundle for ICU4J, followed by optional encoding",
+        r"failed to load root collator \(ucadata.icu\) - %s",
+        r"is about 300kB larger than the ucadata-implicithan\.icu version\.",
+        r"the ucadata-unihan\.icu version of the collation root data",
+    ]
+    FILENAME_PATTERNS = [r"genrb", r"uconv"]
     VERSION_PATTERNS = [
-        r"icu[_-]([0-9]+\.[0-9]+\.[0-9]+)",
-        r"ICU ([0-9]+\.[0-9]+\.[0-9]+)",
-        r"icu[_-][relas-]*((0*(?:[1-6][0-9]?))+(\-[0-9]+)*)",
+        r"icu-([0-9]+\.[0-9]+(\.[0-9]+)?)",
+        r"ICU ([0-9]+\.[0-9]+(\.[0-9]+)?)",
     ]
     VENDOR_PRODUCT = [("icu-project", "international_components_for_unicode")]

test/condensed-downloads/icu-3.6-1.el4.rf.x86_64.rpm.tar.gz

@@ -4,30 +4,50 @@
 mapping_test_data = [
     {
         "product": "international_components_for_unicode",
-        "version": "3.8.1",
-        "version_strings": ["CLIENT icu-release-3-8-1"],
+        "version": "60.3",
+        "version_strings": ["ICU 60.3"],
     },
     {
         "product": "international_components_for_unicode",
-        "version": "3.8.1",
-        "version_strings": ["ICU 3.8.1"],
+        "version": "60.3",
+        "version_strings": ["icu-60.3"],
     },
+]
+package_test_data = [
     {
+        "url": "http://www.rpmfind.net/linux/openmandriva/cooker/repository/x86_64/main/release/",
+        "package_name": "icu-68.2-1-omv4002.x86_64.rpm",
         "product": "international_components_for_unicode",
-        "version": "3.8.1",
-        "version_strings": ["icu-3.8.1"],
+        "version": "68.2",
     },
     {
+        "url": "http://mirror.centos.org/centos/8/BaseOS/aarch64/os/Packages/",
+        "package_name": "icu-60.3-2.el8_1.aarch64.rpm",
         "product": "international_components_for_unicode",
-        "version": "3.8.1",
-        "version_strings": ["icu_3.8.1"],
+        "version": "60.3",
     },
-]
-package_test_data = [
     {
-        "url": "http://www.rpmfind.net/linux/openmandriva/cooker/repository/x86_64/main/release/",
-        "package_name": "icu-68.2-1-omv4002.x86_64.rpm",
+        "url": "http://archive.ubuntu.com/ubuntu/pool/main/i/icu/",
+        "package_name": "icu-devtools_67.1-4_amd64.deb",
         "product": "international_components_for_unicode",
-        "version": "68",
-    }
+        "version": "67.1",
+    },
+    {
+        "url": "https://ftp.netbsd.org/pub/pkgsrc/packages/NetBSD/amd64/8.2/All/",
+        "package_name": "icu-68.2.tgz",
+        "product": "international_components_for_unicode",
+        "version": "68.2",
+    },
+    {
+        "url": "https://rpmfind.net/linux/dag/redhat/el4/en/x86_64/dag/RPMS/",
+        "package_name": "icu-3.6-1.el4.rf.x86_64.rpm",
+        "product": "international_components_for_unicode",
+        "version": "3.6",
+    },
+    # {
+    #     "url": "https://rpmfind.net/linux/dag/redhat/el4/en/x86_64/dag/RPMS/",
+    #     "package_name": "icu-2.6.2-1.2.el4.rf.x86_64.rpm",
+    #     "product": "international_components_for_unicode",
+    #     "version": "2.6.2",
+    # },
 ]