refactor: cosmetic fixes to dev reqs updater (#2415)

Removed unnecessary import
Unindented some code
Renamed some vars to be more clear and consistent
Added some input fixing (`lstrip` whitespaces), also corrected it in yml

Author: Molkree

.github/workflows/update-dev-requirements.py

@@ -1,30 +1,28 @@
 import re
 from importlib.metadata import version
-from typing import List
 
 new_pins = {"pre-commit": version("pre-commit")}
 pre_commit_path = ".pre-commit-config.yaml"
 with open(pre_commit_path) as f:
     tools = f.read().split("repo")
-    for tool in tools:
-        package_match = re.search("id: (.*)", tool)
-        if not package_match:
-            continue
-        version_match = re.search("rev: (.*)", tool)
-        if not version_match:
-            continue
-        new_pins[package_match.group(1)] = version_match.group(1)
+for tool in tools:
+    package_match = re.search("id: (.*)", tool)
+    if not package_match:
+        continue
+    version_match = re.search("rev: (.*)", tool)
+    if not version_match:
+        continue
+    new_pins[package_match.group(1).lstrip()] = version_match.group(1).lstrip()
 
-lines: List[str] = []
 requirements_path = "dev-requirements.txt"
 with open(requirements_path) as f:
-    lines = f.readlines()
-    for ind, line in enumerate(lines):
-        package_match = re.search("(.*)==(.*)", line)
-        if not package_match:
-            continue
-        package_name = package_match.group(1)
-        if package_name in new_pins:
-            lines[ind] = re.sub("==(.*)", f"=={new_pins[package_name]}", line)
+    tools = f.readlines()
+for ind, tool in enumerate(tools):
+    package_match = re.search("(.*)==(.*)", tool)
+    if not package_match:
+        continue
+    package_name = package_match.group(1)
+    if package_name in new_pins:
+        tools[ind] = re.sub("==(.*)", f"=={new_pins[package_name]}", tool)
 with open(requirements_path, "w") as f:
-    f.writelines(lines)
+    f.writelines(tools)

.pre-commit-config.yaml

@@ -28,6 +28,6 @@ repos:
       args: ["-c", "bandit.conf"]
 
 -   repo: https://github.com/jorisroovers/gitlint
-    rev:  v0.17.0
+    rev: v0.17.0
     hooks:
     - id: gitlint