fix: noscan bug fixes (#5283)

Signed-off-by: joydeep049 <[email protected]>

Author: joydeep049

cve_bin_tool/cli.py

@@ -1164,9 +1164,13 @@ def main(argv=None):
                         LOGGER.debug(f"Triage Data: {triage_data}")
                         parsed_data[product_info] = triage_data
 
-                    # Always call get_cves to collect component information
-                    # The method handles both normal and no-scan modes internally
-                    cve_scanner.get_cves(product_info, triage_data)
+                    if not args["no_scan"]:
+                        cve_scanner.get_cves(product_info, triage_data)
+                    else:
+                        # In no-scan mode, still populate all_product_data for display
+                        if product_info not in cve_scanner.all_product_data:
+                            cve_scanner.all_product_data[product_info] = 0
+                        cve_scanner.all_product_data[product_info] = 0
             total_files = version_scanner.total_scanned_files
             LOGGER.info(f"Total files: {total_files}")
 

cve_bin_tool/output_engine/console.py

@@ -160,6 +160,8 @@ def _output_console_nowrap(
             if all_product_data[product_data] != 0 or no_scan:
                 if offline:
                     latest_stable_version = "UNKNOWN (offline mode)"
+                elif no_scan:
+                    latest_stable_version = "N/A (no-scan mode)"
                 else:
                     latest_stable_version = get_latest_upstream_stable_version(
                         product_data

cve_bin_tool/parsers/parse.py

@@ -93,9 +93,14 @@ def parse(filename, output, cve_db, logger):
     Parses the given filename using the appropriate parser.
     """
     parsers = []
+    filename_basename = os.path.basename(filename)
+
     for file in list(valid_files.keys()):
-        if file in output:
+        # Check if this file matches a parser pattern
+        # Either through output (for binary files) or direct filename match (for language files)
+        if file in output or file == filename_basename:
             for valid_file_parser in valid_files[file]:
                 parsers.append(valid_file_parser(cve_db, logger))
+
     for parser in parsers:
         yield from parser.run_checker(filename)

cve_bin_tool/version_scanner.py

@@ -262,45 +262,41 @@ def scan_file(self, filename: str) -> Iterator[ScanInfo]:
         # check if it's a Linux kernel image
         is_linux_kernel, output = self.is_linux_kernel(filename)
 
-        # In no-scan mode, also check if it's a language-specific file
-        is_language_file = False
-        if self.no_scan:
-            # Check if filename matches any language parser patterns
-            for pattern in valid_files.keys():
-                if pattern in filename:
-                    is_language_file = True
-                    break
+        # Check if this file matches any language parser patterns
+        filename_basename = Path(filename).name
+        is_language_file = filename_basename in self.language_checkers
 
+        # In no-scan mode, allow language files even if they're not binary
+        # In normal mode, require the file to be executable or a language file
         if not is_exec and not is_linux_kernel and not is_language_file:
             return None
 
-        # parse binary file's strings
-        lines = parse_strings(filename)
+        # parse binary file's strings (only for binary files)
+        lines = ""
+        if is_exec or is_linux_kernel:
+            lines = parse_strings(filename)
 
         if not self.no_scan and not self.cve_db:
             self.logger.info("No Database Object Found: Fallback to No-Scan Mode")
 
-        if output:
+        # Check for language parsers first
+        if output or is_language_file:
             valid_file = False
             for file in list(self.language_checkers.keys()):
-                valid_file = valid_file | (file in output)
+                valid_file = (
+                    valid_file | (file in output)
+                    if output
+                    else (file == filename_basename)
+                )
             if valid_file:
-                for scan_info in parse(filename, output, self.cve_db, self.logger):
+                for scan_info in parse(
+                    filename, output or "", self.cve_db, self.logger
+                ):
                     yield ScanInfo(scan_info.product_info, "".join(self.file_stack))
 
-        # In no-scan mode, also try to parse language-specific files directly
-        if self.no_scan and is_language_file:
-            # Create a mock output string that includes the filename pattern
-            for pattern in valid_files.keys():
-                if pattern in filename:
-                    mock_output = f"mock: {pattern}"
-                    for scan_info in parse(
-                        filename, mock_output, self.cve_db, self.logger
-                    ):
-                        yield ScanInfo(scan_info.product_info, "".join(self.file_stack))
-                    break
-
-        yield from self.run_checkers(filename, lines)
+        # Only run binary checkers on binary files
+        if is_exec or is_linux_kernel:
+            yield from self.run_checkers(filename, lines)
 
     def run_checkers(self, filename: str, lines: str) -> Iterator[ScanInfo]:
         """process a Set of checker objects, run them on file lines,