ci(fuzzing): treat timeout as a successful workflow run #5256
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we hit the fuzzing timeout, it means no crashes happenened, therefore it makes no sense to treat it as a workflow failure. "timeout" returns an exit code 124 when this happens, and by default the Github runners treat non-zero ones as a failure. Change the logic to convert the exit code 124 to 0 (success) and pass everything else (legitimate failures) through. Closes intel#5244. Signed-off-by: Alex T. <[email protected]>
alex-ter
force-pushed
the
alex-ter/gh5244-fuzz-better-timeout-handling
branch
from
0b05c7a to
fe3b9ab
Compare
|
Rebased onto |
|
The Linux test failure looks like something spurious, doesn't it? The same thing happens in my other PR #5257, but in the "3.10" check. |
|
This might be related to me having re-run the cache job and it maybe hadn't been finished before I started these tests. I'm going to re-run the failing ones and see. But I agree that it's not related to this PR. |
|
Thank you. Passing now, could you please re-run those on #5257 too? |
terriko
approved these changes
Aug 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we hit the fuzzing timeout, it means no crashes happenened, therefore it makes no sense to treat it as a workflow failure.
"timeout" returns an exit code 124 when this happens, and by default the Github runners treat non-zero ones as a failure.
Change the logic to convert the exit code 124 to 0 (success) and pass everything else (legitimate failures) through.
Tested via GH actions in my fork:
Closes #5244.