model: slr: Correct reuse of x variable in best_fit_line

pdxjohnny · pdxjohnny · commit cf385fb4aaa0 · 2020-07-23T20:29:42.000-07:00
Coverity: 294621

Signed-off-by: John Andersen &lt;johnandersenpdx@gmail.com&gt;
diff --git a/dffml/model/slr.py b/dffml/model/slr.py
@@ -41,7 +41,7 @@ def best_fit_line(x, y):
         (mean_x ** 2) - statistics.mean(matrix_multiply(x, x))
     )
     b = mean_y - (m * mean_x)
-    regression_line = [m * x + b for x in x]
+    regression_line = [m * x_element + b for x_element in x]
     accuracy = coeff_of_deter(y, regression_line)
     return (m, b, accuracy)
 

Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ def best_fit_line(x, y):`
`41`	`41`	`(mean_x ** 2) - statistics.mean(matrix_multiply(x, x))`
`42`	`42`	`)`
`43`	`43`	`b = mean_y - (m * mean_x)`
`44`		`- regression_line = [m * x + b for x in x]`
	`44`	`+ regression_line = [m * x_element + b for x_element in x]`
`45`	`45`	`accuracy = coeff_of_deter(y, regression_line)`
`46`	`46`	`return (m, b, accuracy)`
`47`	`47`