Skip to content
This repository was archived by the owner on Aug 25, 2024. It is now read-only.

Commit d5c4f8a

Browse files
author
John Andersen
committed
df: memory: opimps instantiated withconfig()
* MemoryOperationImplementationNetwork instantiates OperationImplementations using their `withconfig()` method, allowing them to receive arguments, which are taken from the uppermost level of the config, NOT addressed under memory-opimp-network-operation-config-key. Fixes: #77 Signed-off-by: John Andersen <[email protected]>
1 parent 81a0e35 commit d5c4f8a

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
88
### Changed
99
- OperationImplementation add_label and add_orig_label methods now use op.name
1010
instead of ENTRY_POINT_ORIG_LABEL and ENTRY_POINT_NAME.
11+
### Fixed
12+
- MemoryOperationImplementationNetwork instantiates OperationImplementations
13+
using their `withconfig()` method.
1114

1215
## [0.2.0] - 2019-05-23
1316
### Added

dffml/df/memory.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -681,7 +681,7 @@ def config(cls, config, *above) -> BaseConfig:
681681
return MemoryOperationImplementationNetworkConfig(
682682
operations={imp.op.name: imp \
683683
for imp in \
684-
[Imp(BaseConfig()) \
684+
[Imp.withconfig(config, 'opimp') \
685685
for Imp in cls.config_get(config, above, 'opimps')]}
686686
)
687687

0 commit comments

Comments
 (0)