skel: model: Correct reuse of x variable in best_fit_line

pdxjohnny · pdxjohnny · commit f77d06b5d10a · 2020-07-23T20:29:42.000-07:00
Coverity: 294623

Signed-off-by: John Andersen &lt;johnandersenpdx@gmail.com&gt;
diff --git a/dffml/skel/model/REPLACE_IMPORT_PACKAGE_NAME/myslr.py b/dffml/skel/model/REPLACE_IMPORT_PACKAGE_NAME/myslr.py
@@ -45,7 +45,7 @@ def best_fit_line(x, y):
         (mean_x ** 2) - statistics.mean(matrix_multiply(x, x))
     )
     b = mean_y - (m * mean_x)
-    regression_line = [m * x + b for x in x]
+    regression_line = [m * x_element + b for x_element in x]
     accuracy = coeff_of_deter(y, regression_line)
     return m, b, accuracy
 

Original file line number	Diff line number	Diff line change
`@@ -45,7 +45,7 @@ def best_fit_line(x, y):`
`45`	`45`	`(mean_x ** 2) - statistics.mean(matrix_multiply(x, x))`
`46`	`46`	`)`
`47`	`47`	`b = mean_y - (m * mean_x)`
`48`		`- regression_line = [m * x + b for x in x]`
	`48`	`+ regression_line = [m * x_element + b for x_element in x]`
`49`	`49`	`accuracy = coeff_of_deter(y, regression_line)`
`50`	`50`	`return m, b, accuracy`
`51`	`51`