feature: Make Features a collections.UserList

Signed-off-by: John Andersen <[email protected]>

Author: pdxjohnny

dffml/base.py

@@ -9,6 +9,7 @@
 import argparse
 import functools
 import contextlib
+import collections
 import dataclasses
 from argparse import ArgumentParser
 from typing import Dict, Any, Type, Optional
@@ -122,7 +123,7 @@ def mkarg(field):
     if field.type == bool:
         arg["action"] = "store_true"
     elif inspect.isclass(field.type):
-        if issubclass(field.type, list):
+        if issubclass(field.type, (list, collections.UserList)):
             arg["nargs"] = "+"
             if not hasattr(field.type, "SINGLETON"):
                 raise AttributeError(

dffml/feature/feature.py

@@ -7,6 +7,7 @@
 import abc
 import pydoc
 import asyncio
+import collections
 from contextlib import AsyncExitStack
 from typing import List, Dict, Type, Any
 
@@ -219,7 +220,7 @@ def length(self) -> int:
     return DefinedFeature(name=name, dtype=dtype, length=length)
 
 
-class Features(list):
+class Features(collections.UserList):
 
     TIMEOUT: int = 60 * 2
     SINGLETON = Feature
@@ -232,10 +233,10 @@ def __init__(self, *args: Feature, timeout: int = None) -> None:
         self.timeout = timeout if not timeout is None else self.TIMEOUT
 
     def names(self) -> List[str]:
-        return list(({feature.NAME: True for feature in self}).keys())
+        return list(({feature.NAME: True for feature in self.data}).keys())
 
     def export(self):
-        return {feature.NAME: feature.export() for feature in self}
+        return {feature.NAME: feature.export() for feature in self.data}
 
     @classmethod
     def _fromdict(cls, **kwargs):
@@ -251,7 +252,7 @@ def _fromdict(cls, **kwargs):
     async def __aenter__(self):
         self._stack = AsyncExitStack()
         await self._stack.__aenter__()
-        for item in self:
+        for item in self.data:
             await self._stack.enter_async_context(item)
         return self