Temporarily disable LLVM opaque pointers

This can be reverted once opaque pointer support is added.

Author: alexbaden

omniscidb/QueryEngine/CMakeLists.txt

@@ -185,6 +185,11 @@ set(hdk_default_runtime_functions_module_dependencies
     GroupByRuntime.cpp
     TopKRuntime.cpp)
 
+list(APPEND DISABLE_OPAQUE_POINTERS_CMD "")
+if(${LLVM_PACKAGE_VERSION} VERSION_GREATER_EQUAL "15")
+    list(APPEND DISABLE_OPAQUE_POINTERS_CMD "-Xclang" "-no-opaque-pointers")
+endif()
+
 # Adds a custom command for producing llvm bitcode modules out of a .cpp source.
 # Any additional arguments are treated as clang args and bypassed as-is.
 function(precompile_llvm_module SOURCE_FILE SUFFIX)
@@ -195,7 +200,7 @@ function(precompile_llvm_module SOURCE_FILE SUFFIX)
         DEPENDS ${hdk_default_runtime_functions_module_dependencies} ${SOURCE_FILE}
         OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/${result_module_name}
         COMMAND ${llvm_clangpp_cmd}
-        ARGS -std=c++17 ${RT_OPT_FLAGS} ${ARGN} -c -emit-llvm
+        ARGS -std=c++17 ${RT_OPT_FLAGS} ${ARGN} -c -emit-llvm ${DISABLE_OPAQUE_POINTERS_CMD}
         ${CLANG_SDK_INC} ${CLANG_CRT_INC} ${MAPD_DEFINITIONS} -DEXECUTE_INCLUDE
         -o ${CMAKE_CURRENT_BINARY_DIR}/${result_module_name}
         -I ${CMAKE_CURRENT_SOURCE_DIR}/../
@@ -272,7 +277,7 @@ add_custom_command(
         DEPENDS ExtensionFunctions.hpp ExtensionFunctionsArray.hpp ExtensionFunctionsTesting.hpp
         OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/ExtensionFunctions.ast.raw
         COMMAND ${llvm_clangpp_cmd}
-        ARGS -DNO_BOOST -std=c++17 -fsyntax-only -Xclang -ast-dump -fno-diagnostics-color -Wno-return-type-c-linkage
+        ARGS -DNO_BOOST -std=c++17 -fsyntax-only -Xclang -ast-dump -fno-diagnostics-color -Wno-return-type-c-linkage ${DISABLE_OPAQUE_POINTERS_CMD}
         -I ${CMAKE_CURRENT_SOURCE_DIR}/../ ${CMAKE_CURRENT_SOURCE_DIR}/ExtensionFunctions.hpp > ${CMAKE_CURRENT_BINARY_DIR}/ExtensionFunctions.ast.raw)
 
 add_custom_command(

omniscidb/QueryEngine/Execute.cpp

@@ -156,6 +156,11 @@ Executor::Executor(const ExecutorId executor_id,
     , temporary_tables_(nullptr)
     , input_table_info_cache_(this)
     , thread_id_(logger::thread_id()) {
+#if LLVM_VERSION_MAJOR > 14
+  // temporarily disable opaque pointers
+  context_->setOpaquePointers(false);
+#endif
+
   if (executor_id_ > INVALID_EXECUTOR_ID - 1) {
     throw std::runtime_error("Too many executors!");
   }

omniscidb/Tests/L0MgrExecuteTest.cpp

@@ -27,6 +27,10 @@ std::string SPIRVExecuteTest::generateSimpleSPIRV() {
   using namespace llvm;
   // See source at https://github.com/kurapov-peter/L0Snippets
   LLVMContext ctx;
+#if LLVM_VERSION_MAJOR > 14
+  // temporarily disable opaque pointers
+  ctx.setOpaquePointers(false);
+#endif
   std::unique_ptr<Module> module = std::make_unique<Module>("code_generated", ctx);
   module->setTargetTriple("spir-unknown-unknown");
   IRBuilder<> builder(ctx);
@@ -157,7 +161,12 @@ std::unique_ptr<llvm::Module> read_gen_module_from_bc(const std::string& bc_file
 std::string mangle_spirv_builtin(const llvm::Function& func) {
   CHECK(func.getName().startswith("__spirv_"));
   std::string new_name;
+#if LLVM_VERSION_MAJOR > 14
+  mangleOpenClBuiltin(
+      func.getName().str(), func.getArg(0)->getType(), /*pointer_types=*/{}, new_name);
+#else
   mangleOpenClBuiltin(func.getName().str(), func.getArg(0)->getType(), new_name);
+#endif
   return new_name;
 }
 }  // namespace

omniscidb/Tests/SpirvBuildTest.cpp

@@ -23,6 +23,10 @@ TEST(SPIRVBuildTest, TranslateSimple) {
   using namespace llvm;
   // See source at https://github.com/kurapov-peter/L0Snippets
   LLVMContext ctx;
+#if LLVM_VERSION_MAJOR > 14
+  // temporarily disable opaque pointers
+  ctx.setOpaquePointers(false);
+#endif
   std::unique_ptr<Module> module = std::make_unique<Module>("code_generated", ctx);
   module->setTargetTriple("spir-unknown-unknown");
   IRBuilder<> builder(ctx);