Skip to content
This repository was archived by the owner on May 9, 2024. It is now read-only.

Commit 37b45c3

Browse files
committed
Support debug timers in config builder.
Signed-off-by: ienkovich <[email protected]>
1 parent e271280 commit 37b45c3

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

omniscidb/ConfigBuilder/ConfigBuilder.cpp

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -637,6 +637,13 @@ bool ConfigBuilder::parseCommandLineArgs(int argc,
637637
"time. This option can be used to split data import and execution for performance "
638638
"measurements.");
639639

640+
// external
641+
opt_desc.add_options()("enable-debug-timer",
642+
po::value<bool>(&g_enable_debug_timer)
643+
->default_value(g_enable_debug_timer)
644+
->implicit_value(true),
645+
"Enable debug timers in logger.");
646+
640647
if (allow_gtest_flags) {
641648
opt_desc.add_options()("gtest_list_tests", "list all test");
642649
opt_desc.add_options()("gtest_filter", "filters tests, use --help for details");

python/pyhdk/_common.pyx

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -184,11 +184,7 @@ cdef class TypeInfo:
184184
def __repr__(self):
185185
return self.c_type_info.toString()
186186

187-
def buildConfig(*, enable_debug_timer=None, enable_union=False, log_dir="hdk_log", **kwargs):
188-
global g_enable_debug_timer
189-
if enable_debug_timer is not None:
190-
g_enable_debug_timer = enable_debug_timer
191-
187+
def buildConfig(*, log_dir="hdk_log", **kwargs):
192188
# Remove legacy params to provide better compatibility with PyOmniSciDbe
193189
kwargs.pop("enable_union", None)
194190
kwargs.pop("enable_thrift_logs", None)

0 commit comments

Comments
 (0)