Re-enable ASAN build (#535)

* Re-enabled ASAN build

* Fix review comment

Author: leshikus

.github/workflows/build-docker.yml

@@ -70,6 +70,7 @@ jobs:
 
       - name: Start the container
         run:  |
+          set -vx
           mkdir -p build
           docker run -id --name build.${{ inputs.name }} --network host build.${{ inputs.name }}:latest
           docker cp . build.${{ inputs.name }}:/_work

.github/workflows/main.yml

@@ -32,6 +32,13 @@ jobs:
       name: clang
       options: -DCMAKE_C_COMPILER=clang -DCMAKE_CXX_COMPILER=clang++
 
+  build-asan:
+    name: Build
+    uses: ./.github/workflows/build.yml
+    with:
+      name: asan
+      options: -DENABLE_ASAN=on
+
   build-l0:
     name: Build
     uses: ./.github/workflows/build.yml
@@ -82,20 +89,21 @@ jobs:
       test: sanity
 
   asan:
-    name: Asan test (Gtests)
+    name: ASAN generate cache (Gtests)
     needs: build
     uses: ./.github/workflows/test.yml
     with:
       cache-suffix: ${{ needs.build.outputs.cache-suffix }}
       test: asan
 
-#  test-asan-docker:
-#    needs: [build-asan, asan]
-#    uses: ./.github/workflows/test-docker.yml
-#    with:
-#      build-name: asan
-#      reset-cache: ${{ !!inputs.reset-cache }}
-
+  test-asan-docker:
+    name: ASAN docker test (Gtests)
+    needs: [build-asan, asan]
+    uses: ./.github/workflows/test-docker.yml
+    with:
+      name: conda
+      build-name: asan
+      reset-cache: ${{ !!inputs.reset-cache }}
 
   build-cuda-docker:
     name: Build
@@ -168,3 +176,4 @@ jobs:
     name: PyHDK (Pytest)
     uses: ./.github/workflows/pytest.yml
 
+

.github/workflows/test-docker.yml

@@ -34,9 +34,20 @@ jobs:
           echo RUN_STAMP=docker-${{ runner.os }}-${{ inputs.name }} >>$GITHUB_ENV
 
       - uses: actions/download-artifact@v3
+        if: inputs.build-name != 'asan'
         with:
           name: ${{ env.RUN_STAMP }}-${{ inputs.build-name }}
 
+      - uses: actions/download-artifact@v3
+        if: inputs.build-name == 'asan'
+        with:
+          name: ${{ runner.os }}-asan-build
+
+      - uses: actions/download-artifact@v3
+        if: inputs.build-name == 'asan'
+        with:
+          name: ${{ runner.os }}-asan-cache
+
       - name: Unpack build files, create Dockerfile
         run: |
           tar -zxf build.tgz
@@ -73,7 +84,13 @@ jobs:
       - name: ASAN test
         if: inputs.build-name == 'asan'
         run: |
-          echo FIXME docker exec -u ghrunner hdk-build.${{ inputs.name }} bash -c 'cd /_work/omniscidb/build/Tests && ./ArrowBasedExecuteTest --use-rel-alg-cache=cache.txt'
+          docker cp cache.tgz hdk-build.${{ inputs.name }}:/_work/
+          docker exec hdk-build.${{ inputs.name }} chown -R ghrunner:ghrunner /_work/
+          docker exec -u ghrunner hdk-build.${{ inputs.name }} tar -zxf /_work/cache.tgz -C /_work/build/omniscidb/Tests 
+          docker exec -u ghrunner hdk-build.${{ inputs.name }} conda update conda
+          docker exec -u ghrunner hdk-build.${{ inputs.name }} conda env update -f /_work/omniscidb/scripts/mapd-deps-conda-dev-env.yml
+          docker exec -u ghrunner hdk-build.${{ inputs.name }} conda install -n omnisci-dev -c conda-forge gtest
+          docker exec -u ghrunner hdk-build.${{ inputs.name }} conda run --no-capture-output -n omnisci-dev bash -cvx 'export LD_LIBRARY_PATH=$(find /_work -name "*.so" -exec dirname {} \; | sort -u | tr "\n" :)$LD_LIBRARY_PATH; cd /_work/build/omniscidb/Tests && ldd ./ArrowBasedExecuteTest && ./ArrowBasedExecuteTest --use-rel-alg-cache=cache.txt'
 
       - name: L0 Sanity test
         if: inputs.name == 'l0'
@@ -85,4 +102,3 @@ jobs:
         if: always()
         run: docker stop hdk-build.${{ inputs.name }} || true
 
-

.github/workflows/test.yml

@@ -91,6 +91,6 @@ jobs:
         if: inputs.test == 'asan'
         uses: actions/upload-artifact@v3
         with:
-          name: docker-${{ env.RUN_STAMP }}-asan
+          name: ${{ runner.os }}-asan-cache
           path: /tmp/cache.tgz
 

docker/Dockerfile.conda

@@ -0,0 +1,8 @@
+# Conda
+RUN curl -o Miniconda3-latest-Linux-x86_64.sh -L https://repo.anaconda.com/miniconda/Miniconda3-latest-Linux-x86_64.sh && \
+    sh Miniconda3-latest-Linux-x86_64.sh -u -b -p /usr/share/miniconda && \
+    chown -R ghrunner:ghrunner /usr/share/miniconda && \
+    rm -f Miniconda3-latest-Linux-x86_64.sh
+
+ENV PATH /usr/share/miniconda/envs/omnisci-dev/bin:/usr/share/miniconda/bin:$PATH
+