Move quantile runtime to static code.

Signed-off-by: ienkovich <[email protected]>

Author: ienkovich

omniscidb/QueryEngine/CMakeLists.txt

@@ -73,6 +73,7 @@ set(query_engine_source_files
     OutputBufferInitialization.cpp
     QueryPhysicalInputsCollector.cpp
     PlanState.cpp
+    QuantileRuntime.cpp
     QueryRewrite.cpp
     QueryTemplateGenerator.cpp
     QueryExecutionContext.cpp
@@ -136,6 +137,7 @@ set(group_by_hash_test_files
         GroupByHashTest.cpp
         MurmurHash.cpp
         DynamicWatchdog.cpp
+        QuantileRuntime.cpp
         RuntimeFunctions.cpp
         )
 

omniscidb/QueryEngine/GroupByRuntime.cpp

@@ -19,7 +19,6 @@
 
 #ifndef __CUDACC__
 #include "QueryEngine/TopKAggRuntime.h"
-#include "Shared/quantile.h"
 #endif
 
 extern "C" RUNTIME_EXPORT ALWAYS_INLINE DEVICE uint32_t
@@ -413,16 +412,12 @@ DEF_AGG_TOPK_ALL(double, double)
 #undef DEF_AGG_TOPK_SKIP_VAL
 #undef DEF_AGG_TOPK
 
-template <typename ValueType>
-void agg_quantile_impl(int64_t* agg, ValueType val) {
-  auto* quantile = reinterpret_cast<hdk::quantile::Quantile*>(*agg);
-  quantile->add<ValueType>(val);
-}
-
-#define DEF_AGG_QUANTILE(val_type, suffix)                                   \
-  extern "C" RUNTIME_EXPORT ALWAYS_INLINE DEVICE void agg_quantile_##suffix( \
-      int64_t* agg, val_type val) {                                          \
-    agg_quantile_impl<val_type>(agg, val);                                   \
+#define DEF_AGG_QUANTILE(val_type, suffix)                                        \
+  extern "C" RUNTIME_EXPORT DEVICE void agg_quantile_impl_##suffix(int64_t* agg,  \
+                                                                   val_type val); \
+  extern "C" RUNTIME_EXPORT ALWAYS_INLINE DEVICE void agg_quantile_##suffix(      \
+      int64_t* agg, val_type val) {                                               \
+    agg_quantile_impl_##suffix(agg, val);                                         \
   }
 
 #define DEF_AGG_QUANTILE_SKIP_VAL(val_type, suffix)                                     \

omniscidb/QueryEngine/QuantileRuntime.cpp

@@ -0,0 +1,21 @@
+/*
+ * Copyright (C) 2023 Intel Corporation
+ *
+ * SPDX-License-Identifier: Apache-2.0
+ */
+
+#include "Shared/quantile.h"
+
+#define DEF_AGG_QUANTILE_IMPL(val_type, suffix)                                    \
+  extern "C" RUNTIME_EXPORT DEVICE void agg_quantile_impl_##suffix(int64_t* agg,   \
+                                                                   val_type val) { \
+    auto* quantile = reinterpret_cast<hdk::quantile::Quantile*>(*agg);             \
+    quantile->add<val_type>(val);                                                  \
+  }
+
+DEF_AGG_QUANTILE_IMPL(int8_t, int8)
+DEF_AGG_QUANTILE_IMPL(int16_t, int16)
+DEF_AGG_QUANTILE_IMPL(int32_t, int32)
+DEF_AGG_QUANTILE_IMPL(int64_t, int64)
+DEF_AGG_QUANTILE_IMPL(float, float)
+DEF_AGG_QUANTILE_IMPL(double, double)

omniscidb/Shared/InlineNullValues.h

@@ -28,6 +28,7 @@
 #include <cstdint>
 #include <cstdlib>
 #include <limits>
+#include <type_traits>
 
 #define NULL_BOOLEAN INT8_MIN
 #define NULL_TINYINT INT8_MIN

omniscidb/Shared/quantile.h

@@ -11,6 +11,8 @@
 
 #include "IR/OpTypeEnums.h"
 
+#include <algorithm>
+#include <cmath>
 #include <cstdint>
 #include <vector>
 
@@ -260,18 +262,18 @@ class Quantile {
     size_t right_idx;
     switch (interpolation) {
       case ir::Interpolation::kLower:
-        left_idx = right_idx = floor(pos);
+        left_idx = right_idx = std::floor(pos);
         break;
       case ir::Interpolation::kHigher:
-        left_idx = right_idx = ceil(pos);
+        left_idx = right_idx = std::ceil(pos);
         break;
       case ir::Interpolation::kNearest:
-        left_idx = right_idx = round(pos);
+        left_idx = right_idx = std::round(pos);
         break;
       case ir::Interpolation::kMidpoint:
       case ir::Interpolation::kLinear:
-        left_idx = floor(pos);
-        right_idx = ceil(pos);
+        left_idx = std::floor(pos);
+        right_idx = std::ceil(pos);
         break;
     }