Properly handle HDK boolean type checking in comparison with SQLite

alexbaden · alexbaden · commit bcd51c3b8492 · 2023-10-12T12:50:00.000-05:00
diff --git a/omniscidb/Tests/ArrowSQLRunner/SQLiteComparator.cpp b/omniscidb/Tests/ArrowSQLRunner/SQLiteComparator.cpp
@@ -46,8 +46,10 @@ void checkTypeConsistency(const int ref_col_type, const hdk::ir::Type* col_type)
     CHECK_EQ(SQLITE_INTEGER, ref_col_type);
   } else if (col_type->isFloatingPoint() || col_type->isDecimal()) {
     CHECK(ref_col_type == SQLITE_FLOAT || ref_col_type == SQLITE_INTEGER);
+  } else if (col_type->isBoolean()) {
+    CHECK(ref_col_type == SQLITE_INTEGER || ref_col_type == SQLITE_TEXT);
   } else {
-    CHECK_EQ(SQLITE_TEXT, ref_col_type);
+    CHECK_EQ(SQLITE_TEXT, ref_col_type) << "HDK Type: " << col_type->toString();
   }
 }
 

Original file line number	Diff line number	Diff line change
`@@ -46,8 +46,10 @@ void checkTypeConsistency(const int ref_col_type, const hdk::ir::Type* col_type)`
`46`	`46`	`CHECK_EQ(SQLITE_INTEGER, ref_col_type);`
`47`	`47`	`} else if (col_type->isFloatingPoint() \|\| col_type->isDecimal()) {`
`48`	`48`	`CHECK(ref_col_type == SQLITE_FLOAT \|\| ref_col_type == SQLITE_INTEGER);`
	`49`	`+ } else if (col_type->isBoolean()) {`
	`50`	`+ CHECK(ref_col_type == SQLITE_INTEGER \|\| ref_col_type == SQLITE_TEXT);`
`49`	`51`	`} else {`
`50`		`- CHECK_EQ(SQLITE_TEXT, ref_col_type);`
	`52`	`+ CHECK_EQ(SQLITE_TEXT, ref_col_type) << "HDK Type: " << col_type->toString();`
`51`	`53`	`}`
`52`	`54`	`}`
`53`	`55`