Skip to content
This repository was archived by the owner on May 9, 2024. It is now read-only.

Commit ddaf04c

Browse files
committed
Add missing cpu-only options to some tests
1 parent d5a2381 commit ddaf04c

File tree

5 files changed

+25
-6
lines changed

5 files changed

+25
-6
lines changed

omniscidb/Tests/ArrayTest.cpp

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -925,6 +925,7 @@ TEST_F(MultiFragArrayParallelLinearizationTest, IndexedArrayJoin) {
925925
}
926926

927927
int main(int argc, char** argv) {
928+
auto config = std::make_shared<Config>();
928929
g_is_test_env = true;
929930

930931
TestHelpers::init_logger_stderr_only(argc, argv);
@@ -936,14 +937,18 @@ int main(int argc, char** argv) {
936937
logger::LogOptions log_options(argv[0]);
937938
log_options.max_files_ = 0; // stderr only by default
938939
desc.add(log_options.get_options());
940+
desc.add_options()("cpu-only",
941+
po::value<bool>(&config->exec.cpu_only)
942+
->default_value(config->exec.cpu_only)
943+
->implicit_value(true));
939944

940945
po::variables_map vm;
941946
po::store(po::command_line_parser(argc, argv).options(desc).run(), vm);
942947
po::notify(vm);
943948

944-
init();
945-
config().exec.heterogeneous.allow_cpu_retry = true;
946-
config().exec.heterogeneous.allow_query_step_cpu_retry = true;
949+
config->exec.heterogeneous.allow_cpu_retry = true;
950+
config->exec.heterogeneous.allow_query_step_cpu_retry = true;
951+
init(config);
947952

948953
int err{0};
949954
try {

omniscidb/Tests/GroupByTest.cpp

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -364,6 +364,7 @@ TEST_F(BigCardinalityThresholdTest, EmptyFilters) {
364364
}
365365

366366
int main(int argc, char** argv) {
367+
auto config = std::make_shared<Config>();
367368
g_is_test_env = true;
368369

369370
TestHelpers::init_logger_stderr_only(argc, argv);
@@ -375,14 +376,18 @@ int main(int argc, char** argv) {
375376
logger::LogOptions log_options(argv[0]);
376377
log_options.max_files_ = 0; // stderr only by default
377378
desc.add(log_options.get_options());
379+
desc.add_options()("cpu-only",
380+
po::value<bool>(&config->exec.cpu_only)
381+
->default_value(config->exec.cpu_only)
382+
->implicit_value(true));
378383

379384
po::variables_map vm;
380385
po::store(po::command_line_parser(argc, argv).options(desc).run(), vm);
381386
po::notify(vm);
382387

383-
init();
384-
config().exec.heterogeneous.allow_cpu_retry = false;
385-
config().exec.heterogeneous.allow_query_step_cpu_retry = false;
388+
config->exec.heterogeneous.allow_cpu_retry = false;
389+
config->exec.heterogeneous.allow_query_step_cpu_retry = false;
390+
init(config);
386391

387392
int err{0};
388393
try {

omniscidb/Tests/NoCatalogSqlTest.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,7 @@ class NoCatalogSqlTest : public ::testing::Test {
111111
protected:
112112
static void SetUpTestSuite() {
113113
config_ = std::make_shared<Config>();
114+
config_->exec.cpu_only = true;
114115

115116
schema_provider_ = std::make_shared<TestSchemaProvider>();
116117

@@ -264,6 +265,7 @@ TEST_F(NoCatalogSqlTest, MultipleCalciteMultipleThreads) {
264265
TEST(CalciteReinitTest, SingleThread) {
265266
auto schema_provider = std::make_shared<TestSchemaProvider>();
266267
auto config = std::make_shared<Config>();
268+
config->exec.cpu_only = true;
267269
for (int i = 0; i < 10; ++i) {
268270
auto calcite = CalciteMgr::get();
269271
auto query_ra =
@@ -275,6 +277,7 @@ TEST(CalciteReinitTest, SingleThread) {
275277
TEST(CalciteReinitTest, MultipleThreads) {
276278
auto schema_provider = std::make_shared<TestSchemaProvider>();
277279
auto config = std::make_shared<Config>();
280+
config->exec.cpu_only = true;
278281
for (int i = 0; i < 10; ++i) {
279282
auto f = std::async(std::launch::async, [schema_provider, config]() {
280283
auto calcite = CalciteMgr::get();
@@ -296,6 +299,7 @@ void parse_cli_args_to_globals(int argc, char* argv[]) {
296299
desc.add_options()("use-groupby-buffer-desc",
297300
po::bool_switch()->default_value(false),
298301
"Use GroupBy Buffer Descriptor for hash tables.");
302+
desc.add_options()("cpu-only", "ignored option");
299303

300304
po::variables_map vm;
301305

omniscidb/Tests/ResultSetArrowConversion.cpp

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,10 @@ void parse_cli_args(int argc, char* argv[], ConfigPtr config) {
7070
po::value<bool>(&config->rs.enable_columnar_output)
7171
->default_value(config->rs.enable_columnar_output),
7272
"Enable columnar_output");
73+
desc.add_options()("cpu-only",
74+
po::value<bool>(&config->exec.cpu_only)
75+
->default_value(config->exec.cpu_only)
76+
->implicit_value(true));
7377

7478
logger::LogOptions log_options(argv[0]);
7579
log_options.severity_ = logger::Severity::FATAL;

omniscidb/Tests/StringDictionaryTest.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -874,6 +874,7 @@ int main(int argc, char** argv) {
874874
->default_value(g_cache_string_hash)
875875
->implicit_value(true),
876876
"Cache string hash values in the string dictionary server during import.");
877+
desc.add_options()("cpu-only", "ignored option");
877878

878879
logger::LogOptions log_options(argv[0]);
879880
log_options.severity_ = logger::Severity::FATAL;

0 commit comments

Comments
 (0)