Skip to content
This repository was archived by the owner on May 9, 2024. It is now read-only.

Commit e61e929

Browse files
committed
s
1 parent b584fe2 commit e61e929

File tree

3 files changed

+127
-193
lines changed

3 files changed

+127
-193
lines changed

omniscidb/QueryEngine/JoinHashTable/Builders/PerfectHashTableBuilder.h

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -166,8 +166,6 @@ class PerfectJoinHashTableBuilder {
166166
0);
167167

168168
auto cpu_hash_table_buff = reinterpret_cast<int32_t*>(hash_table_->getCpuBuffer());
169-
// const int thread_count = cpu_threads();
170-
// std::vector<std::thread> init_cpu_buff_threads;
171169

172170
{
173171
auto timer_init = DEBUG_TIMER("CPU One-To-One Perfect-Hash: init_hash_join_buff");
@@ -176,13 +174,11 @@ class PerfectJoinHashTableBuilder {
176174
hash_join_invalid_val);
177175
}
178176
const bool for_semi_join = for_semi_anti_join(join_type);
179-
// std::atomic<int> err{0};
180177
{
181178
auto timer_fill =
182179
DEBUG_TIMER("CPU One-To-One Perfect-Hash: fill_hash_join_buff_bucketized_cpu");
183180

184181
{
185-
// int partial_err = 0;
186182
JoinColumnTypeInfo type_info{static_cast<size_t>(type->size()),
187183
col_range.getIntMin(),
188184
col_range.getIntMax(),
@@ -204,7 +200,6 @@ class PerfectJoinHashTableBuilder {
204200
if (error) {
205201
// Too many hash entries, need to retry with a 1:many table
206202
hash_table_ = nullptr; // clear the hash table buffer
207-
// LOG(ERROR) << "cpu hash_tabel error: " << error;
208203
throw NeedsOneToManyHash();
209204
}
210205
}

0 commit comments

Comments
 (0)