Fix warnings.

Signed-off-by: ienkovich <[email protected]>

Author: ienkovich

omniscidb/ArrowStorage/ArrowStorage.cpp

@@ -478,7 +478,7 @@ void ArrowStorage::materializeDictionary(DictionaryData* dict) {
       VLOG(1) << "Materialized string dictionary for column " << col_id << " in table "
               << table_id;
       for (auto& frag : table.fragments) {
-        CHECK_LT(col_id, frag.metadata.size());
+        CHECK_LT(static_cast<size_t>(col_id), frag.metadata.size());
         auto& meta = frag.metadata[col_id];
         // compute chunk stats is multi threaded, so we single thread this
         meta->fillChunkStats(

omniscidb/QueryEngine/JoinHashTable/Runtime/HashJoinRuntime.cpp

@@ -188,10 +188,8 @@ DEVICE void SUFFIX(init_hash_join_buff)(int32_t* groups_buffer,
                     [=](const tbb::blocked_range<int64_t>& r) {
                       const auto start_idx = r.begin();
                       const auto end_idx = r.end();
-                      for (auto entry_idx = start_idx; entry_idx != end_idx;
-                           ++entry_idx) {
-                        groups_buffer[entry_idx] = invalid_slot_val;
-                      }
+                      init_hash_join_buff_cpu(
+                          groups_buffer, invalid_slot_val, start_idx, end_idx);
                     });
 #endif
 }

omniscidb/QueryEngine/RowFuncBuilder.cpp

@@ -993,7 +993,6 @@ bool RowFuncBuilder::codegenShuffle(
                                                      partition_byte_streams,
                                                      LL_INT(target_idx)),
                                 "target_byte_stream_" + std::to_string(target_idx));
-      size_t chosen_bytes = query_mem_desc.getPaddedSlotWidthBytes(target_idx);
 
       target_builder(target_expr, executor_, query_mem_desc, co);
       target_builder.codegenSingleTarget(this,

omniscidb/ResultSet/ArrowResultSetConverter.cpp

@@ -1372,7 +1372,7 @@ std::shared_ptr<arrow::Table> ArrowResultSetConverter::getArrowTable(
                                  ? results_->entryCount()
                                  : std::min(size_t(top_n_), results_->entryCount());
 
-  CHECK_GT(entry_count, 0);
+  CHECK_GT(entry_count, (size_t)0);
 
   std::vector<ColumnBuilder> builders(col_count);
   for (size_t col_idx = 0; col_idx < col_count; ++col_idx) {
@@ -1455,7 +1455,7 @@ std::shared_ptr<arrow::Table> ArrowResultSetConverter::getArrowTable(
     for (size_t i = 0; i < col_count; i++) {
       row_size_bytes += results_->colType(i)->size();
     }
-    CHECK_GT(row_size_bytes, 0);
+    CHECK_GT(row_size_bytes, (size_t)0);
 
     const size_t stride = std::clamp(entry_count / cpu_threads() / 2,
                                      65536 / row_size_bytes,
@@ -1797,7 +1797,7 @@ void ArrowResultSetConverter::initializeColumnBuilder(
       const auto& unique_strings = unique_ids_and_strings.second;
       ARROW_THROW_NOT_OK(str_array_builder.AppendValues(unique_strings));
       const int32_t num_unique_strings = unique_strings.size();
-      CHECK_EQ(num_unique_strings, unique_ids.size());
+      CHECK_EQ(static_cast<size_t>(num_unique_strings), unique_ids.size());
       // We need to remap ALL string id values given the Arrow dictionary
       // will have "holes", i.e. it is a sparse representation of the underlying
       // StringDictionary

omniscidb/Tests/ResultSetArrowConversion.cpp

@@ -60,45 +60,6 @@ using namespace ArrowTestHelpers;
 //  HELPERS
 namespace {
 
-// Processes command line args
-void parse_cli_args(int argc, char* argv[], ConfigPtr config) {
-  namespace po = boost::program_options;
-
-  po::options_description desc("Options");
-
-  desc.add_options()("help,h", "Print help messages ");
-  desc.add_options()("enable-columnar-output",
-                     po::value<bool>(&config->rs.enable_columnar_output)
-                         ->default_value(config->rs.enable_columnar_output),
-                     "Enable columnar_output");
-  desc.add_options()("cpu-only",
-                     po::value<bool>(&config->exec.cpu_only)
-                         ->default_value(config->exec.cpu_only)
-                         ->implicit_value(true));
-
-  logger::LogOptions log_options(argv[0]);
-  log_options.severity_ = logger::Severity::FATAL;
-  log_options.set_options();  // update default values
-  desc.add(log_options.get_options());
-
-  try {
-    po::variables_map vm;
-    po::store(po::command_line_parser(argc, argv).options(desc).run(), vm);
-    po::notify(vm);
-
-    if (vm.count("help")) {
-      std::cout << desc;
-      std::exit(EXIT_SUCCESS);
-    }
-
-    logger::init(log_options);
-  } catch (boost::program_options::error& e) {
-    std::cerr << "Usage Error: " << e.what() << std::endl;
-    std::cout << desc;
-    std::exit(EXIT_FAILURE);
-  }
-}
-
 std::string getFilePath(const std::string& file_name) {
   return TEST_SOURCE_PATH + std::string("/EmbeddedDataFiles/") + file_name;
 }