Remove pid/lock code and associated syscalls

Author: alexbaden

omniscidb/OSDependent/Unix/omnisci_fs.cpp

@@ -28,21 +28,6 @@ int get_page_size() {
   return getpagesize();
 }
 
-size_t file_size(const int fd) {
-  struct stat buf;
-  int err = fstat(fd, &buf);
-  CHECK_EQ(0, err);
-  return buf.st_size;
-}
-
-int open(const char* path, int flags, int mode) {
-  return ::open(path, flags, mode);
-}
-
-void close(const int fd) {
-  ::close(fd);
-}
-
 ::FILE* popen(const char* command, const char* type) {
   return ::popen(command, type);
 }
@@ -51,8 +36,4 @@ int32_t pclose(::FILE* fh) {
   return ::pclose(fh);
 }
 
-int32_t ftruncate(const int32_t fd, int64_t length) {
-  return ::ftruncate(fd, length);
-}
-
 }  // namespace omnisci

omniscidb/OSDependent/Windows/omnisci_fs.cpp

@@ -30,21 +30,6 @@
 
 namespace omnisci {
 
-size_t file_size(const int fd) {
-  struct _stat64i32 buf;
-  const auto err = _fstat64i32(fd, &buf);
-  CHECK_EQ(0, err);
-  return buf.st_size;
-}
-
-int open(const char* path, int flags, int mode) {
-  return _open(path, flags, mode);
-}
-
-void close(const int fd) {
-  _close(fd);
-}
-
 ::FILE* popen(const char* command, const char* type) {
   return _popen(command, type);
 }
@@ -57,7 +42,4 @@ int get_page_size() {
   return 4096;  // TODO: reasonable guess for now
 }
 
-int32_t ftruncate(const int32_t fd, int64_t length) {
-  return _chsize_s(fd, length);
-}
 }  // namespace omnisci

omniscidb/OSDependent/omnisci_fs.h

@@ -22,17 +22,10 @@
 
 namespace omnisci {
 
-size_t file_size(const int fd);
-
-int open(const char* path, int flags, int mode);
-
-void close(const int fd);
-
 ::FILE* popen(const char* command, const char* type);
 
 int32_t pclose(::FILE* fh);
 
 int get_page_size();
 
-int32_t ftruncate(const int32_t fd, int64_t length);
 }  // namespace omnisci

omniscidb/Utils/CommandLineOptions.cpp

@@ -315,38 +315,6 @@ void CommandLineOptions::validate() {
                              "'");
   }
 
-  {
-    const auto lock_file = boost::filesystem::path(base_path) / "omnisci_server_pid.lck";
-    auto pid = std::to_string(getpid());
-
-    int pid_fd = omnisci::open(lock_file.string().c_str(), O_RDWR | O_CREAT, 0644);
-    if (pid_fd == -1) {
-      auto err = std::string("Failed to open PID file ") + lock_file.string().c_str() +
-                 ". " + strerror(errno) + ".";
-      throw std::runtime_error(err);
-    }
-// TODO: support lock on Windows
-#ifndef _WIN32
-    if (lockf(pid_fd, F_TLOCK, 0) == -1) {
-      omnisci::close(pid_fd);
-      auto err = std::string("Another OmniSci Server is using data directory ") +
-                 base_path + ".";
-      throw std::runtime_error(err);
-    }
-#endif
-    if (omnisci::ftruncate(pid_fd, 0) == -1) {
-      omnisci::close(pid_fd);
-      auto err = std::string("Failed to truncate PID file ") +
-                 lock_file.string().c_str() + ". " + strerror(errno) + ".";
-      throw std::runtime_error(err);
-    }
-    if (write(pid_fd, pid.c_str(), pid.length()) == -1) {
-      omnisci::close(pid_fd);
-      auto err = std::string("Failed to write PID file ") + lock_file.string().c_str() +
-                 ". " + strerror(errno) + ".";
-      throw std::runtime_error(err);
-    }
-  }
   boost::algorithm::trim_if(db_query_file, boost::is_any_of("\"'"));
   if (db_query_file.length() > 0 && !boost::filesystem::exists(db_query_file)) {
     throw std::runtime_error("File containing DB queries " + db_query_file +