Skip to content

Commit 105c44c

Browse files
AnBodrovaigcbot
authored andcommitted
Revert "Set 128 grf size by default"
.
1 parent 18ea0df commit 105c44c

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

IGC/VectorCompiler/lib/GenXCodeGen/GenXCisaBuilder.cpp

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -949,8 +949,7 @@ static void addKernelAttrsFromMetadata(VISAKernel &Kernel,
949949
Kernel.AddKernelAttribute("NBarrierCnt", sizeof(BarrierCnt), &BarrierCnt);
950950
}
951951

952-
// Default number of registers.
953-
unsigned NumGRF = 128;
952+
int NumGRF = -1;
954953
// Set by compile option.
955954
if (BC->isAutoLargeGRFMode())
956955
NumGRF = 0;
@@ -962,7 +961,9 @@ static void addKernelAttrsFromMetadata(VISAKernel &Kernel,
962961
if (NumGRFPerKernel == 0 || Subtarget->isValidGRFSize(NumGRFPerKernel))
963962
NumGRF = NumGRFPerKernel;
964963
}
965-
Kernel.AddKernelAttribute("NumGRF", sizeof(NumGRF), &NumGRF);
964+
965+
if (NumGRF != -1)
966+
Kernel.AddKernelAttribute("NumGRF", sizeof(NumGRF), &NumGRF);
966967
}
967968

968969
// Legalize name for using as filename or in visa asm

IGC/VectorCompiler/test/CisaBuilder/grf_size.ll

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,12 +27,12 @@ define dllexport spir_kernel void @test_auto(i32 %arg) #0 {
2727
ret void
2828
}
2929

30-
; CHECK: .kernel_attr NumGRF=128
30+
; CHECK-NOT: .kernel_attr NumGRF
3131
define dllexport spir_kernel void @test_default(i32 %arg) #0 {
3232
ret void
3333
}
3434

35-
; CHECK: .kernel_attr NumGRF=128
35+
; CHECK-NOT: .kernel_attr NumGRF
3636
define dllexport spir_kernel void @test_invalid(i32 %arg) #0 {
3737
ret void
3838
}

0 commit comments

Comments
 (0)