Reduce usage of pointer element types (29).

This change replaces calls to getNonOpaquePtrEltTy with element type
information got through other means. This change is part of the effort
to support opaque pointers in newer LLVM versions.

Author: ViacheslavRb

IGC/Compiler/CISACodeGen/PayloadMapping.cpp

@@ -497,7 +497,7 @@ uint PayloadMapping::GetNonAdjustedNumPayloadElements_Sample(const SampleIntrins
     EOPCODE opCode = GetOpCode(inst);
     llvm::Type* cubeTextureType = GetResourceDimensionType(*inst->getModule(), RESOURCE_DIMENSION_TYPE::DIM_CUBE_TYPE);
     llvm::Type* cubeArrayTextureType = GetResourceDimensionType(*inst->getModule(), RESOURCE_DIMENSION_TYPE::DIM_CUBE_ARRAY_TYPE);
-    llvm::Type* textureType = IGCLLVM::getNonOpaquePtrEltTy(inst->getTextureValue()->getType());
+    llvm::Type* textureType = inst->getTexturePtrEltTy();
     bool isCube = (textureType == cubeTextureType || textureType == cubeArrayTextureType);
     ValidateNumberofSources(opCode, isCube, numSources);
 

IGC/Compiler/DynamicTextureFolding.cpp

@@ -44,7 +44,7 @@ void DynamicTextureFolding::FoldSingleTextureValue(CallInst& I)
    if (SamplerLoadIntrinsic * lInst = dyn_cast<SamplerLoadIntrinsic>(&I))
     {
         addrSpace = lInst->getTextureValue()->getType()->getPointerAddressSpace();
-        Type* textureType = IGCLLVM::getNonOpaquePtrEltTy(lInst->getTextureValue()->getType());
+        Type* textureType = lInst->getTexturePtrEltTy();
         if (textureType == type1DArray || textureType == type2DArray || textureType == typeCubeArray)
         {
             skipBoundaryCheck = 0;

IGC/Compiler/FixSampleDInputs.cpp

@@ -61,7 +61,7 @@ IGC_INITIALIZE_PASS_END(FixSampleDInputsPass, PASS_FLAG, PASS_DESCRIPTION, PASS_
             for (Instruction& inst : BB)
             {
                 SampleIntrinsic* sampleInst = dyn_cast<SampleIntrinsic>(&inst);
-                Type* textureType = sampleInst ? IGCLLVM::getNonOpaquePtrEltTy(sampleInst->getTextureValue()->getType()) : nullptr;
+                Type* textureType = sampleInst ? sampleInst->getTexturePtrEltTy() : nullptr;
                 // 3D/Cube/CubeArray access is emulated in CodeGen, see EmitPass::emulateSampleD()
                 if (sampleInst &&
                     (textureType != volumeTextureType && textureType != cubeTextureType && textureType != cubeArrayTextureType))
@@ -97,7 +97,7 @@ IGC_INITIALIZE_PASS_END(FixSampleDInputsPass, PASS_FLAG, PASS_DESCRIPTION, PASS_
                         uint mlodParamIndex = 11;
                         Value* mlod_r = sampleInst->getArgOperand(mlodParamIndex); // MLOD
                         Type* type2DArray = GetResourceDimensionType(*M, RESOURCE_DIMENSION_TYPE::DIM_2D_ARRAY_TYPE);
-                        Type* typeTex = IGCLLVM::getNonOpaquePtrEltTy(sampleInst->getTextureValue()->getType());
+                        Type* typeTex = sampleInst->getTexturePtrEltTy();
                         if (typeTex == type2DArray)
                         {
                             // combine MLOD and R

IGC/Compiler/TranslateToProgrammableOffsetsPass.cpp

@@ -450,7 +450,7 @@ inline bool needsSampleDEmulation(const SampleIntrinsic* inst)
     Type* volumeTextureType = GetResourceDimensionType(M, RESOURCE_DIMENSION_TYPE::DIM_3D_TYPE);
     Type* cubeTextureType = GetResourceDimensionType(M, RESOURCE_DIMENSION_TYPE::DIM_CUBE_TYPE);
     Type* cubeArrayTextureType = GetResourceDimensionType(M, RESOURCE_DIMENSION_TYPE::DIM_CUBE_ARRAY_TYPE);
-    Type* textureType = IGCLLVM::getNonOpaquePtrEltTy(inst->getTextureValue()->getType());
+    Type* textureType = inst->getTexturePtrEltTy();
     if (textureType == cubeTextureType ||
         textureType == cubeArrayTextureType ||
         textureType == volumeTextureType)

IGC/GenISAIntrinsics/GenIntrinsicInst.h

@@ -46,6 +46,7 @@ See LICENSE.TXT for details.
 
 #include "llvmWrapper/IR/Instructions.h"
 #include "llvmWrapper/Support/Alignment.h"
+#include "llvmWrapper/IR/Type.h"
 #include "usc_gen7_types.h"
 
 namespace llvm {
@@ -499,6 +500,11 @@ class SamplerLoadIntrinsic : public GenIntrinsicInst {
             return false;
         }
     }
+
+    Type* getTexturePtrEltTy() const {
+        Value* textureVal = this->getTextureValue();
+        return textureVal ? IGCLLVM::getNonOpaquePtrEltTy(textureVal->getType()) : nullptr;
+    }
 };
 
 class LdMSIntrinsic : public SamplerLoadIntrinsic {
@@ -851,6 +857,11 @@ class SampleIntrinsic : public GenIntrinsicInst {
         }
         return false;
     }
+
+    Type* getTexturePtrEltTy() const {
+        Value* textureVal = this->getTextureValue();
+        return textureVal ? IGCLLVM::getNonOpaquePtrEltTy(textureVal->getType()) : nullptr;
+    }
 };
 
 class LdRawIntrinsic : public GenIntrinsicInst {