Skip to content

Commit 404a72a

Browse files
lukaszgotszaldintelsys_zuul
authored andcommitted
refactoring CMakeLists.txt about SPIRV-Tools
Change-Id: Ic1728c973cac911234eeef00aab21df0d044b688
1 parent 846e717 commit 404a72a

File tree

1 file changed

+9
-7
lines changed

1 file changed

+9
-7
lines changed

IGC/CMakeLists.txt

Lines changed: 9 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -3414,8 +3414,8 @@ if(IGC_BUILD__SPIRV_TOOLS_ENABLED)
34143414
message(STATUS "============================ SPIRV-Tools project ============================")
34153415
set(IGC_BUILD__SPIRV-Headers_DIR "${BS_DIR_EXTERNAL_COMPONENTS}/build-tools/SPIRV-Headers")
34163416
set(IGC_BUILD__SPIRV-Tools_DIR "${BS_DIR_EXTERNAL_COMPONENTS}/build-tools/SPIRV-Tools")
3417-
set(IGC_BUILD__SPIRV-Headers_OUTPUT_DIR "${IGC_BUILD__TOOLS_OUTPUT_DIR}/SPIRV-Headers")
3418-
set(IGC_BUILD__SPIRV-Tools_OUTPUT_DIR "${IGC_BUILD__TOOLS_OUTPUT_DIR}/SPIRV-Tools")
3417+
set(IGC_BUILD__SPIRV-Headers_OUTPUT_DIR "${IGC_OPTION__OUTPUT_DIR}/SPIRV-Headers")
3418+
set(IGC_BUILD__SPIRV-Tools_OUTPUT_DIR "${IGC_OPTION__OUTPUT_DIR}/SPIRV-Tools")
34193419
set(SPIRV-Headers_SOURCE_DIR "${IGC_BUILD__SPIRV-Headers_DIR}")
34203420
option(SKIP_SPIRV_TOOLS_INSTALL "Skip SPIRV-Tools installation" ON)
34213421
option(SPIRV_SKIP_TESTS "Skip building SPIRV-Tools tests along with the library" ON)
@@ -3432,8 +3432,8 @@ if(IGC_BUILD__SPIRV_TOOLS_ENABLED)
34323432
message(STATUS "Option SPIRV_HEADERS_SKIP_INSTALL: ${SPIRV_HEADERS_SKIP_INSTALL}")
34333433
message(STATUS "Option SPIRV_HEADERS_SKIP_EXAMPLES: ${SPIRV_HEADERS_SKIP_EXAMPLES}")
34343434
# add_subdirectory("${IGC_BUILD__SPIRV-Headers_DIR}" "${IGC_BUILD__SPIRV-Headers_OUTPUT_DIR}")
3435-
add_subdirectory("${IGC_BUILD__SPIRV-Tools_DIR}" "${IGC_BUILD__SPIRV-Tools_OUTPUT_DIR}")
3436-
set(IGC_BUILD__PROJ__SPIRV-Tools "SPIRV-Tools")
3435+
add_subdirectory("${IGC_BUILD__SPIRV-Tools_DIR}" "${IGC_BUILD__SPIRV-Tools_OUTPUT_DIR}" EXCLUDE_FROM_ALL)
3436+
set(IGC_BUILD__PROJ__SPIRV-Tools "SPIRV-Tools") # same name as in subdirectory
34373437
unset(IGC_BUILD__SPIRV-Headers_OUTPUT_DIR)
34383438
unset(IGC_BUILD__SPIRV-Tools_OUTPUT_DIR)
34393439
unset(SPIRV-Headers_SOURCE_DIR)
@@ -3444,8 +3444,10 @@ if(IGC_BUILD__SPIRV_TOOLS_ENABLED)
34443444
unset(SPIRV_HEADERS_SKIP_EXAMPLES)
34453445
include_directories("${IGC_BUILD__SPIRV-Headers_DIR}/include")
34463446
include_directories("${IGC_BUILD__SPIRV-Tools_DIR}/include")
3447+
set_target_properties("${IGC_BUILD__PROJ__SPIRV-Tools}" PROPERTIES EXCLUDE_FROM_DEFAULT_BUILD_RELEASE TRUE)
34473448
set_property(DIRECTORY APPEND PROPERTY COMPILE_DEFINITIONS_DEBUG IGC_SPIRV_TOOLS_ENABLED)
34483449
set_property(DIRECTORY APPEND PROPERTY COMPILE_DEFINITIONS_RELEASEINTERNAL IGC_SPIRV_TOOLS_ENABLED)
3450+
igc_sg_define(IGC__SPIRV-Tools)
34493451
message(STATUS "=============================================================================")
34503452
endif()
34513453

@@ -3774,9 +3776,9 @@ foreach(_libBuildSuffix ${IGC_BUILD__MAIN_IGC_LIB_SUFFIXES})
37743776
)
37753777
else()
37763778
target_link_libraries("${IGC_BUILD__PROJ${_libBuildSuffix}}" PRIVATE
3777-
${_targetLinkLineCommon}
3778-
$<$<NOT:$<CONFIG:Release>>:${_targetLinkLineDebugAndReleaseInternalOnly}>
3779-
${CMAKE_DL_LIBS}
3779+
"${_targetLinkLineCommon}"
3780+
"$<$<NOT:$<CONFIG:Release>>:${_targetLinkLineDebugAndReleaseInternalOnly}>"
3781+
"${CMAKE_DL_LIBS}"
37803782
)
37813783
# Link line for shared / dynamic library requires only library project (all static libs are linked inside).
37823784
set_property(TARGET "${IGC_BUILD__PROJ${_libBuildSuffix}}" PROPERTY LINK_INTERFACE_LIBRARIES "")

0 commit comments

Comments
 (0)