Skip to content

Commit 4d1aab8

Browse files
lukaszgotszaldintelsys_zuul
authored andcommitted
use IGC_ASSERT in InstructionCombining.cpp
Change-Id: I6fb053a1aa87c0ae7a1edeb2fcf1f1332e545f2b
1 parent 02ca07e commit 4d1aab8

File tree

2 files changed

+15
-1
lines changed

2 files changed

+15
-1
lines changed

IGC/Compiler/Optimizer/IGCInstCombiner/4.0/InstructionCombining.cpp

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2464,7 +2464,7 @@ Instruction *InstCombiner::visitExtractValueInst(ExtractValueInst &EV) {
24642464
}
24652465

24662466
/// Return 'true' if the given typeinfo will match anything.
2467-
static bool isCatchAll(EHPersonality Personality, Constant *TypeInfo) {
2467+
static bool isCatchAll(EHPersonality Personality, Constant* TypeInfo) {
24682468
switch (Personality) {
24692469
case EHPersonality::GNU_C:
24702470
case EHPersonality::GNU_C_SjLj:
@@ -2485,12 +2485,19 @@ static bool isCatchAll(EHPersonality Personality, Constant *TypeInfo) {
24852485
case EHPersonality::MSVC_Win64SEH:
24862486
case EHPersonality::MSVC_CXX:
24872487
case EHPersonality::CoreCLR:
2488+
IGC_ASSERT(nullptr != TypeInfo);
24882489
return TypeInfo->isNullValue();
24892490
}
24902491
IGC_ASSERT_EXIT_MESSAGE(0, "invalid enum");
24912492
}
24922493

24932494
static bool shorter_filter(const Value *LHS, const Value *RHS) {
2495+
IGC_ASSERT(nullptr != LHS);
2496+
IGC_ASSERT(nullptr != LHS->getType());
2497+
IGC_ASSERT(nullptr != cast<ArrayType>(LHS->getType()));
2498+
IGC_ASSERT(nullptr != RHS);
2499+
IGC_ASSERT(nullptr != RHS->getType());
2500+
IGC_ASSERT(nullptr != cast<ArrayType>(RHS->getType()));
24942501
return
24952502
cast<ArrayType>(LHS->getType())->getNumElements()
24962503
<

IGC/Compiler/Optimizer/IGCInstCombiner/7.0/InstructionCombining.cpp

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2624,12 +2624,19 @@ static bool isCatchAll(EHPersonality Personality, Constant* TypeInfo) {
26242624
case EHPersonality::MSVC_CXX:
26252625
case EHPersonality::CoreCLR:
26262626
case EHPersonality::Wasm_CXX:
2627+
IGC_ASSERT(nullptr != TypeInfo);
26272628
return TypeInfo->isNullValue();
26282629
}
26292630
IGC_ASSERT_EXIT_MESSAGE(0, "invalid enum");
26302631
}
26312632

26322633
static bool shorter_filter(const Value* LHS, const Value* RHS) {
2634+
IGC_ASSERT(nullptr != LHS);
2635+
IGC_ASSERT(nullptr != LHS->getType());
2636+
IGC_ASSERT(nullptr != cast<ArrayType>(LHS->getType()));
2637+
IGC_ASSERT(nullptr != RHS);
2638+
IGC_ASSERT(nullptr != RHS->getType());
2639+
IGC_ASSERT(nullptr != cast<ArrayType>(RHS->getType()));
26332640
return
26342641
cast<ArrayType>(LHS->getType())->getNumElements()
26352642
<

0 commit comments

Comments
 (0)