Initialize members, use std::move, use const& in loops - try 2

Coverity related fixes.
Initialize members, use std::move, use const& in loops,
organize code in a way that's easier to analyze for Coverity.

Author: fda0

IGC/AdaptorCommon/RayTracing/TraceRayInlineLoweringPass.cpp

@@ -34,7 +34,7 @@ using namespace RTStackFormat;
 //Lowering pass for Synchronous raytracing intrinsics known as TraceRayInline/RayQuery
 class TraceRayInlineLoweringPass : public FunctionPass
 {
-    LoopInfo* LI;
+    LoopInfo* LI = nullptr;
 public:
     TraceRayInlineLoweringPass() : FunctionPass(ID) {
         initializeTraceRayInlineLoweringPassPass(*PassRegistry::getPassRegistry());

IGC/Compiler/CISACodeGen/CShader.cpp

@@ -37,25 +37,6 @@ CShader::CShader(Function *pFunc, CShaderProgram *pProgram, GenericShaderState &
     , encoder()
 {
     m_ctx = m_parent->GetContext();
-    m_WI = nullptr;
-    m_deSSA = nullptr;
-    m_coalescingEngine = nullptr;
-    m_DL = nullptr;
-    m_FGA = nullptr;
-    m_VRA = nullptr;
-    m_RLA = nullptr;
-    m_EmitPass = nullptr;
-    m_HW_TID = nullptr;
-
-    m_shaderStats = nullptr;
-    // [OCL] preAnalysis()/ParseShaderSpecificOpcode() must
-    // set this to ture if there is any stateless access.
-    m_HasGlobalStatelessMemoryAccess = false;
-    m_HasConstantStatelessMemoryAccess = false;
-
-    m_SavedSRetPtr = nullptr;
-    m_FP = nullptr;
-    m_SavedFP = nullptr;
 
     bool SepSpillPvtSS = SeparateSpillAndScratch(m_ctx);
     bool SeparateScratchWA =

IGC/Compiler/CISACodeGen/ResourceLoopUnroll.cpp

@@ -152,12 +152,6 @@ bool ResourceLoopUnroll::emitResourceLoop(llvm::CallInst* CI)
 
             GetResourceOperand(inst, resource, pairTexture, texture, sampler);
 
-            // either resource (ld instr), or sample instr must be available
-            if (!resource && (!pairTexture || !texture || !sampler))
-            {
-                IGC_ASSERT(0);
-            }
-
             // Fill UniformSendBB
             builder.SetInsertPoint(checkBB);
 
@@ -170,7 +164,7 @@ bool ResourceLoopUnroll::emitResourceLoop(llvm::CallInst* CI)
                 resourceNew->setName("firstActiveRes");
                 cond = builder.CreateICmpEQ(resource, resourceNew);
             }
-            else // then must be sampler
+            else if (pairTexture && texture && sampler) // then must be sampler
             {
                 samplerNew = sampler;
                 textureNew = texture;
@@ -224,6 +218,10 @@ bool ResourceLoopUnroll::emitResourceLoop(llvm::CallInst* CI)
                     cond = samplerCond;
                 }
             }
+            else
+            {
+                IGC_ASSERT(0);
+            }
 
             // Here we swap the last loop load and goto, such as
             // From

IGC/Compiler/CISACodeGen/ShaderCodeGen.hpp

@@ -399,7 +399,7 @@ class CShader
     SIMDMode m_SIMDSize{};
     uint8_t m_numberInstance = 0;
     PushInfo pushInfo;
-    EmitPass* m_EmitPass;
+    EmitPass* m_EmitPass = nullptr;
     uint m_sendStallCycle = 0;
     uint m_staticCycle = 0;
     uint m_loopNestedStallCycle = 0;
@@ -648,19 +648,19 @@ class CShader
         e_alignment preferredAlign);
 
 protected:
-    CShaderProgram* m_parent;
-    CodeGenContext* m_ctx;
-    WIAnalysis* m_WI;
-    DeSSA* m_deSSA;
-    CoalescingEngine* m_coalescingEngine;
-    CodeGenPatternMatch* m_CG;
-    llvm::DominatorTree* m_DT;
-    const llvm::DataLayout* m_DL;
-    GenXFunctionGroupAnalysis* m_FGA;
-    VariableReuseAnalysis* m_VRA;
-    ResourceLoopAnalysis* m_RLA;
-
-    IGC::IGCMD::MetaDataUtils* m_pMdUtils;
+    CShaderProgram* m_parent = nullptr;
+    CodeGenContext* m_ctx = nullptr;
+    WIAnalysis* m_WI = nullptr;
+    DeSSA* m_deSSA = nullptr;
+    CoalescingEngine* m_coalescingEngine = nullptr;
+    CodeGenPatternMatch* m_CG = nullptr;
+    llvm::DominatorTree* m_DT = nullptr;
+    const llvm::DataLayout* m_DL = nullptr;
+    GenXFunctionGroupAnalysis* m_FGA = nullptr;
+    VariableReuseAnalysis* m_VRA = nullptr;
+    ResourceLoopAnalysis* m_RLA = nullptr;
+
+    IGC::IGCMD::MetaDataUtils* m_pMdUtils = nullptr;
 
 #if defined(_DEBUG) || defined(_INTERNAL)
     llvm::SpecificBumpPtrAllocator<CVariable> Allocator;
@@ -698,26 +698,26 @@ class CShader
 
     uint m_maxBlockId = 0;
 
-    CVariable* m_R0;
-    CVariable* m_NULL;
-    CVariable* m_TSC;
-    CVariable* m_SR0;
-    CVariable* m_CR0;
-    CVariable* m_CE0;
-    CVariable* m_MSG0;
-    CVariable* m_DBG;
-    CVariable* m_HW_TID;
-    CVariable* m_SP;
-    CVariable* m_FP;
-    CVariable* m_SavedFP;
-    CVariable* m_ARGV;
+    CVariable* m_R0 = nullptr;
+    CVariable* m_NULL = nullptr;
+    CVariable* m_TSC = nullptr;
+    CVariable* m_SR0 = nullptr;
+    CVariable* m_CR0 = nullptr;
+    CVariable* m_CE0 = nullptr;
+    CVariable* m_MSG0 = nullptr;
+    CVariable* m_DBG = nullptr;
+    CVariable* m_HW_TID = nullptr;
+    CVariable* m_SP = nullptr;
+    CVariable* m_FP = nullptr;
+    CVariable* m_SavedFP = nullptr;
+    CVariable* m_ARGV = nullptr;
     std::array<CVariable*, NUM_ARG_SPACE_RESERVATION_SLOTS> m_ARGVReservedVariables{};
     uint32_t m_ARGVReservedVariablesTotalSize = 0;
-    CVariable* m_RETV;
-    CVariable* m_SavedSRetPtr;
-    CVariable* m_ImplArgBufPtr;
-    CVariable* m_LocalIdBufPtr;
-    CVariable* m_GlobalBufferArg;
+    CVariable* m_RETV = nullptr;
+    CVariable* m_SavedSRetPtr = nullptr;
+    CVariable* m_ImplArgBufPtr = nullptr;
+    CVariable* m_LocalIdBufPtr = nullptr;
+    CVariable* m_GlobalBufferArg = nullptr;
 
     /// holds max number of inputs that can be pushed for this shader unit
     static const uint32_t m_pMaxNumOfPushedInputs;
@@ -731,8 +731,11 @@ class CShader
     // Those two are for stateful token setup. It is a quick
     // special case checking. Once a generic approach is added,
     // this two fields shall be retired.
-    bool m_HasGlobalStatelessMemoryAccess;
-    bool m_HasConstantStatelessMemoryAccess;
+    //
+    // [OCL] preAnalysis()/ParseShaderSpecificOpcode() must
+    // set this to true if there is any stateless access.
+    bool m_HasGlobalStatelessMemoryAccess = false;
+    bool m_HasConstantStatelessMemoryAccess = false;
 
     bool m_HasGlobalAtomics = false;
 

IGC/Compiler/Optimizer/WaveShuffleIndexSinking.cpp

@@ -88,7 +88,7 @@ namespace IGC
                     }
 
                     // Update ShuffleGroup members
-                    HoistOrAnchorInstsIdx = NewHoistOrAnchorInstsIdx;
+                    HoistOrAnchorInstsIdx = std::move(NewHoistOrAnchorInstsIdx);
                     InstChains.push_back( InstChainA );
                     InstChains.push_back( InstChainB );
                     ShuffleOps.push_back( shuffleInst );
@@ -116,7 +116,7 @@ namespace IGC
                     }
 
                     // Update ShuffleGroup members
-                    HoistOrAnchorInstsIdx = NewHoistOrAnchorInstsIdx; // this should be the same size as NewInstChain
+                    HoistOrAnchorInstsIdx = std::move(NewHoistOrAnchorInstsIdx); // this should be the same size as NewInstChain
                     InstChains.push_back( NewInstChain );
                     ShuffleOps.push_back( shuffleInst );
                     return true;

IGC/WrapperLLVM/include/llvmWrapper/IR/Instructions.h

@@ -202,7 +202,7 @@ inline unsigned getArgOperandNo(llvm::CallInst &CI, const llvm::Use *U) {
 // calls through CB.getCalledFunction() would leave indirect calls unhandled.
 inline void setMemoryEffects(llvm::CallBase &CB, IGCLLVM::MemoryEffects ME) {
   CB.removeFnAttrs(ME.getOverridenAttrKinds());
-  for (auto MemAttr : ME.getAsAttributeSet(CB.getContext()))
+  for (const auto& MemAttr : ME.getAsAttributeSet(CB.getContext()))
     CB.addFnAttr(MemAttr);
 }