Call getAnalysis in doFinalization only if it is needed.

PawelJurek · gfxbot · commit 5faeeeccb650 · 2019-03-19T07:04:48.000-07:00
There is a corner case: when we compile a file that has no kernels in it, the analysis is not added to the manager and we can't use it. This could result in a crash

Change-Id: Ia48c276277b35ff0072f4763cb93fe67b586d24d
diff --git a/IGC/Compiler/FindInterestingConstants.cpp b/IGC/Compiler/FindInterestingConstants.cpp
@@ -332,10 +332,10 @@ void FindInterestingConstants::copyInterestingConstants(ContextT* pShaderCtx)
 
 bool FindInterestingConstants::doFinalization(llvm::Module &M)
 {
-    CodeGenContext* ctx = getAnalysis<CodeGenContextWrapper>().getCodeGenContext();
-
     if (m_InterestingConstants.size() != 0)
     {
+        CodeGenContext* ctx = getAnalysis<CodeGenContextWrapper>().getCodeGenContext();
+
         if (ctx->type == ShaderType::PIXEL_SHADER)
         {
             PixelShaderContext* pShaderCtx = static_cast <PixelShaderContext*>(ctx);

Original file line number	Diff line number	Diff line change
`@@ -332,10 +332,10 @@ void FindInterestingConstants::copyInterestingConstants(ContextT* pShaderCtx)`
`332`	`332`
`333`	`333`	`bool FindInterestingConstants::doFinalization(llvm::Module &M)`
`334`	`334`	`{`
`335`		`- CodeGenContext* ctx = getAnalysis<CodeGenContextWrapper>().getCodeGenContext();`
`336`		`-`
`337`	`335`	`if (m_InterestingConstants.size() != 0)`
`338`	`336`	`{`
	`337`	`+ CodeGenContext* ctx = getAnalysis<CodeGenContextWrapper>().getCodeGenContext();`
	`338`	`+`
`339`	`339`	`if (ctx->type == ShaderType::PIXEL_SHADER)`
`340`	`340`	`{`
`341`	`341`	`PixelShaderContext* pShaderCtx = static_cast <PixelShaderContext*>(ctx);`