Apply rule-of-three

Apply rule-of-three by explicitly deleting copy ctors.

Author: smilczek

visa/Attributes.hpp

@@ -121,7 +121,6 @@ class Attributes {
   }
 
   Attributes();
-  ~Attributes() {}
 
   // Set attribute's value
   void setKernelAttr(ID kID, bool v);

visa/BitSet.h

@@ -436,6 +436,8 @@ class SparseBitSet {
   SparseBitSet(const SparseBitSet &&Other)
       : Segments(std::move(Other.Segments)), MaxBits(Other.MaxBits) {}
 
+  ~SparseBitSet() = default;
+
   unsigned getSize() const { return MaxBits; }
 
   void clear() { Segments.clear(); }

visa/FrequencyInfo.h

@@ -59,7 +59,6 @@ class FrequencyInfo {
   void sortBasedOnFreq(std::vector<LiveRange *> &lrs);
   bool hasFreqMetaData(G4_INST *i);
   void deriveRefFreq(G4_BB *bb);
-  ~FrequencyInfo() {}
   void dump() const {}
   void initForRegAlloc(LivenessAnalysis *l);
   void initGRFSpillFillFreq() {

visa/GraphColor.h

@@ -1312,7 +1312,6 @@ class ForbiddenRegs {
     forbiddenVec[(size_t)forbiddenKind::FBD_SCALAR].resize(
         getForbiddenVectorSize(G4_SCALAR));
   };
-  ~ForbiddenRegs(){};
 
   unsigned getForbiddenVectorSize(G4_RegFileKind regKind) const;
   void generateReservedGRFForbidden(unsigned reserveSpillSize);

visa/Mem_Manager.h

@@ -22,6 +22,9 @@ class Mem_Manager {
   Mem_Manager(size_t defaultArenaSize);
   ~Mem_Manager();
 
+  Mem_Manager(const Mem_Manager &) = delete;
+  Mem_Manager &operator=(const Mem_Manager &) = delete;
+
   void *alloc(size_t size) {
     return _arenaManager.AllocDataSpace(size, ArenaHeader::defaultAlign);
   }

visa/Option.h

@@ -332,8 +332,6 @@ class Options {
     }
     explicit VISAOptionsDB(Options *opt)
         : options(opt), optionsMap(static_cast<int>(vISA_NUM_OPTIONS)) {}
-
-    ~VISAOptionsDB() {}
   };
 
   VISAOptionsDB m_vISAOptions;

visa/RPE.h

@@ -18,8 +18,6 @@ class RPE {
   RPE(const GlobalRA &, const LivenessAnalysis *,
       DECLARE_LIST *spills = nullptr);
 
-  ~RPE() {}
-
   void run();
   void runBB(G4_BB *);
   unsigned int getRegisterPressure(G4_INST *inst) {

visa/SpillManagerGMRF.h

@@ -253,8 +253,6 @@ class SpillManagerGRF {
                   const LivenessAnalysis *lvInfo, LSLR_LIST *spilledLSLRs,
                   bool enableSpillSpaceCompression, bool useScratchMsg);
 
-  ~SpillManagerGRF() {}
-
   bool insertSpillFillCode(G4_Kernel *kernel,
                            PointsToAnalysis &pointsToAnalysis);
 

visa/iga/IGALibrary/MemManager/MemManager.hpp

@@ -22,13 +22,13 @@ class MemManager {
   MemManager(size_t defaultArenaSize);
   ~MemManager();
 
+  MemManager(const MemManager &) = delete;
+  MemManager &operator=(const MemManager &) = delete;
+
   void *alloc(size_t size) { return _arenaManager.AllocDataSpace(size); }
 
 private:
   ArenaManager _arenaManager;
-
-  MemManager(const MemManager &) = delete;
-  MemManager &operator=(const MemManager &) = delete;
 };
 } // namespace iga
 #endif