Changes in code.

Author: Dimus77

IGC/Compiler/CISACodeGen/CISABuilder.cpp

@@ -2594,21 +2594,7 @@ namespace IGC
 
     void CEncoder::AddrAdd(CVariable* dst, CVariable* src0, CVariable* src1)
     {
-        // On ICL+ platforms address register must be initialized if it is used
-        // in VxH indirect addressing to avoid out-of-bounds access on inactive
-        // lanes. VISA initializes address register at the beginning of the
-        // shader which is sufficient for shaders that use address register only
-        // for indirect addressing but is not sufficient if shader also uses
-        // address register in send descriptors. The latter case is handled by
-        // the initialization below.
-        // see VISA Optimizer::resetA0()
-        const bool mayUseA0InSendDesc =
-            m_program->GetContext()->m_instrTypes.mayHaveIndirectResources;
-        const bool needsA0Reset =
-            m_program->m_Platform->NeedResetA0forVxHA0();
-
-        if (((mayUseA0InSendDesc && needsA0Reset) ||
-            IGC_IS_FLAG_ENABLED(InitializeAddressRegistersBeforeUse)) &&
+        if (IGC_IS_FLAG_ENABLED(InitializeAddressRegistersBeforeUse) &&
             !dst->IsUniform() &&
             !m_encoderState.m_noMask)
         {

IGC/Compiler/CISACodeGen/CheckInstrTypes.cpp

@@ -91,7 +91,6 @@ CheckInstrTypes::CheckInstrTypes(IGC::SInstrTypes* instrList) : FunctionPass(ID)
     instrList->hasTypedRead = false;
     instrList->hasTypedwrite = false;
     instrList->mayHaveIndirectOperands = false;
-    instrList->mayHaveIndirectResources = false;
     instrList->hasUniformAssumptions = false;
     instrList->hasWaveIntrinsics = false;
     instrList->numPsInputs = 0;
@@ -293,20 +292,6 @@ void CheckInstrTypes::visitCallInst(CallInst& C)
         default:
             break;
         }
-
-        Value* resourcePtr = GetBufferOperand(CI);
-        if (resourcePtr == nullptr)
-        {
-            Value* samplerPtr = nullptr;
-            getTextureAndSamplerOperands(CI, resourcePtr, samplerPtr);
-        }
-        if (resourcePtr &&
-            resourcePtr->getType()->isPointerTy() &&
-            isStatefulAddrSpace(resourcePtr->getType()->getPointerAddressSpace()) &&
-            !IsDirectIdx(resourcePtr->getType()->getPointerAddressSpace()))
-        {
-            g_InstrTypes->mayHaveIndirectResources = true;
-        }
     }
 }
 
@@ -389,10 +374,6 @@ void CheckInstrTypes::visitLoadInst(LoadInst& I)
         {
             g_InstrTypes->hasStorageBufferLoad = true;
         }
-        if (isStatefulAddrSpace(as) && !IsDirectIdx(as))
-        {
-            g_InstrTypes->mayHaveIndirectResources = true;
-        }
         break;
     }
     }
@@ -425,10 +406,6 @@ void CheckInstrTypes::visitStoreInst(StoreInst& I)
         {
             g_InstrTypes->hasStorageBufferStore = true;
         }
-        if (isStatefulAddrSpace(as) && !IsDirectIdx(as))
-        {
-            g_InstrTypes->mayHaveIndirectResources = true;
-        }
         break;
     }
     }

IGC/Compiler/CISACodeGen/Platform.hpp

@@ -279,11 +279,6 @@ bool HSUsesHWBarriers() const
     return (m_platformInfo.eRenderCoreFamily >= IGFX_GEN11_CORE);
 }
 
-bool NeedResetA0forVxHA0() const
-{
-    return (m_platformInfo.eRenderCoreFamily >= IGFX_GEN11_CORE);
-}
-
 bool enableVertexReorderingPhase2() const
 {
     return (m_platformInfo.eRenderCoreFamily >= IGFX_GEN10_CORE);

IGC/Compiler/CodeGenPublic.h

@@ -263,9 +263,6 @@ namespace IGC
         bool hasTypedRead;
         bool hasTypedwrite;
         bool mayHaveIndirectOperands;  //<! true if code may have indirect operands like r5[a0].
-        // true if shader may have indirect texture or buffer.
-        // Note: does not check for indirect sampler
-        bool mayHaveIndirectResources;
         bool hasUniformAssumptions;
         bool hasWaveIntrinsics;
         bool hasPullBary;