Minor fixes and refactors.

Add std::move if it's at the end of variable's scope.

Small refactor + typo fix in tryPrintLabel labmda.

Replace `construct -> push_back` pattern with emplace_back.

Change arg to const ref where makes sense.

Author: smilczek

visa/DebugInfo.cpp

@@ -2044,8 +2044,7 @@ INST_LIST KernelDebugInfo::getDeltaInstructions(G4_BB *bb) {
 
 void SaveRestoreManager::addInst(G4_INST *inst) {
   const IR_Builder &builder = inst->getBuilder();
-  SaveRestoreInfo newSVInfo = {};
-  srInfo.push_back(newSVInfo);
+  srInfo.emplace_back();
   if (srInfo.size() > 1) {
     // Copy over from previous
     // so emitted data is

visa/G4_Kernel.cpp

@@ -1888,16 +1888,14 @@ void G4_Kernel::emitDeviceAsmInstructionsIga(std::ostream &os,
   // there's an empty BB contains only labels. The BB and the following BB will
   // both print those labels. The pair is the pc to label name pair.
   std::set<std::pair<int32_t, std::string>> printedLabels;
-  // tryPrintLable - check if the given label is already printed with the given
+  // tryPrintLabel - check if the given label is already printed with the given
   // pc. Print it if not, and skip it if yes.
   auto tryPrintLabel = [&os, &printedLabels](int32_t label_pc,
                                              const std::string &label_name) {
-    auto label_pair = std::make_pair(label_pc, label_name);
-    // skip if the same label in the set
-    if (printedLabels.find(label_pair) != printedLabels.end())
-      return;
-    os << label_name << ":\n";
-    printedLabels.insert(label_pair);
+    auto [iter, inserted] = printedLabels.emplace(label_pc, label_name);
+    // print if the label is new in the set.
+    if (inserted)
+      os << label_name << ":\n";
   };
 
   for (BB_LIST_ITER itBB = fg.begin(); itBB != fg.end(); ++itBB) {

visa/MetadataDumpRA.cpp

@@ -113,7 +113,7 @@ void MetadataDumpRA::addKernelMD(G4_Kernel* kernel) {
             }
 
             // add this instruction metadata to the kernel's metadata
-            kernelMD.instMetadatas.push_back(instMD);
+            kernelMD.instMetadatas.push_back(std::move(instMD));
             kernelMD.numInsts += 1;
 
         }

visa/SCCAnalysis.cpp

@@ -93,7 +93,7 @@ void SCCAnalysis::findSCC(SCCNode *node) {
       bodyNode->isOnStack = false;
       newSCC.addBB(bodyNode->bb);
     } while (bodyNode != node);
-    SCCs.push_back(newSCC);
+    SCCs.push_back(std::move(newSCC));
   }
 } // findSCC
 

visa/iga/IGALibrary/Frontend/Formatter.cpp

@@ -1383,7 +1383,7 @@ bool Formatter::formatLoadStoreSyntax(const Instruction &i) {
 
   formatMaskAndPredication(i);
 
-  const auto syntax = di.syntax;
+  const auto &syntax = di.syntax;
   startColumn(cols.opCodeExecInfo + 12);
   emit(' ');
   emit(ANSI_MNEMONIC);

visa/iga/IGALibrary/IR/InstBuilder.hpp

@@ -411,7 +411,7 @@ class InstBuilder {
           inst->setLabelSource(opIx, 0, src.type);
           UnresolvedLabel u{src.loc, src.immLabel, inst->getSource(opIx),
                             *inst};
-          m_unresolvedLabels.push_back(u);
+          m_unresolvedLabels.push_back(std::move(u));
         }
       } else if (src.kind == Operand::Kind::IMMEDIATE) {
         inst->setImmediateSource(opIx, src.immValue, src.type);