Skip to content

Commit 7591da2

Browse files
agrabezhigcbot
authored andcommitted
Adding WillReturn attribute to intrinsics with memory(read)
Adding `WillReturn` attributes to all intrinsics with `Ref` memory_effects to solve performance regressions from LLVM 16 transition.
1 parent c1d3475 commit 7591da2

File tree

1 file changed

+18
-0
lines changed

1 file changed

+18
-0
lines changed

IGC/GenISAIntrinsics/generator/input/Intrinsic_definitions.yml

Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -287,6 +287,7 @@ intrinsics:
287287
comment: "owordAttributeIndex"
288288
attributes:
289289
- !AttributeID "NoUnwind"
290+
- !AttributeID "WillReturn"
290291
memory_effects:
291292
- !<MemoryRestriction>
292293
memory_access: !MemoryAccessType Ref
@@ -303,6 +304,7 @@ intrinsics:
303304
comment: "owordAttributeIndex"
304305
attributes:
305306
- !AttributeID "NoUnwind"
307+
- !AttributeID "WillReturn"
306308
memory_effects:
307309
- !<MemoryRestriction>
308310
memory_access: !MemoryAccessType Ref
@@ -993,6 +995,7 @@ intrinsics:
993995
arguments: []
994996
attributes:
995997
- !AttributeID "NoUnwind"
998+
- !AttributeID "WillReturn"
996999
memory_effects:
9971000
- !<MemoryRestriction>
9981001
memory_access: !MemoryAccessType Ref
@@ -1808,6 +1811,7 @@ intrinsics:
18081811
comment: "render target slot"
18091812
attributes:
18101813
- !AttributeID "NoUnwind"
1814+
- !AttributeID "WillReturn"
18111815
memory_effects:
18121816
- !<MemoryRestriction>
18131817
memory_access: !MemoryAccessType Ref
@@ -1828,6 +1832,7 @@ intrinsics:
18281832
comment: "sample index"
18291833
attributes:
18301834
- !AttributeID "NoUnwind"
1835+
- !AttributeID "WillReturn"
18311836
memory_effects:
18321837
- !<MemoryRestriction>
18331838
memory_access: !MemoryAccessType Ref
@@ -2096,6 +2101,7 @@ intrinsics:
20962101
comment: "urb offset"
20972102
attributes:
20982103
- !AttributeID "NoUnwind"
2104+
- !AttributeID "WillReturn"
20992105
memory_effects:
21002106
- !<MemoryRestriction>
21012107
memory_access: !MemoryAccessType Ref
@@ -7847,6 +7853,7 @@ intrinsics:
78477853
attributes:
78487854
- !AttributeID "Convergent"
78497855
- !AttributeID "NoUnwind"
7856+
- !AttributeID "WillReturn"
78507857
memory_effects:
78517858
- !<MemoryRestriction>
78527859
memory_access: !MemoryAccessType Ref
@@ -7868,6 +7875,7 @@ intrinsics:
78687875
attributes:
78697876
- !AttributeID "Convergent"
78707877
- !AttributeID "NoUnwind"
7878+
- !AttributeID "WillReturn"
78717879
memory_effects:
78727880
- !<MemoryRestriction>
78737881
memory_access: !MemoryAccessType Ref
@@ -8011,6 +8019,7 @@ intrinsics:
80118019
attributes:
80128020
- !AttributeID "Convergent"
80138021
- !AttributeID "NoUnwind"
8022+
- !AttributeID "WillReturn"
80148023
memory_effects:
80158024
- !<MemoryRestriction>
80168025
memory_access: !MemoryAccessType Ref
@@ -10061,6 +10070,7 @@ intrinsics:
1006110070
comment: "cache controls options (LSC_CACHE_OPTS)"
1006210071
attributes:
1006310072
- !AttributeID "NoUnwind"
10073+
- !AttributeID "WillReturn"
1006410074
memory_effects:
1006510075
- !<MemoryRestriction>
1006610076
memory_access: !MemoryAccessType Ref
@@ -10089,6 +10099,7 @@ intrinsics:
1008910099
comment: "value to use if predicate is false"
1009010100
attributes:
1009110101
- !AttributeID "NoUnwind"
10102+
- !AttributeID "WillReturn"
1009210103
memory_effects:
1009310104
- !<MemoryRestriction>
1009410105
memory_access: !MemoryAccessType Ref
@@ -10151,6 +10162,7 @@ intrinsics:
1015110162
comment: "cache controls options (LSC_CACHE_OPTS)"
1015210163
attributes:
1015310164
- !AttributeID "NoUnwind"
10165+
- !AttributeID "WillReturn"
1015410166
memory_effects:
1015510167
- !<MemoryRestriction>
1015610168
memory_access: !MemoryAccessType Ref
@@ -10183,6 +10195,7 @@ intrinsics:
1018310195
comment: "cache controls options (LSC_CACHE_OPTS)"
1018410196
attributes:
1018510197
- !AttributeID "NoUnwind"
10198+
- !AttributeID "WillReturn"
1018610199
memory_effects:
1018710200
- !<MemoryRestriction>
1018810201
memory_access: !MemoryAccessType Ref
@@ -10701,6 +10714,7 @@ intrinsics:
1070110714
comment: "primitiveIndex"
1070210715
attributes:
1070310716
- !AttributeID "NoUnwind"
10717+
- !AttributeID "WillReturn"
1070410718
memory_effects:
1070510719
- !<MemoryRestriction>
1070610720
memory_access: !MemoryAccessType Ref
@@ -10721,6 +10735,7 @@ intrinsics:
1072110735
comment: "primitiveIndex : ignored for PrimitiveCount"
1072210736
attributes:
1072310737
- !AttributeID "NoUnwind"
10738+
- !AttributeID "WillReturn"
1072410739
memory_effects:
1072510740
- !<MemoryRestriction>
1072610741
memory_access: !MemoryAccessType Ref
@@ -10791,6 +10806,7 @@ intrinsics:
1079110806
comment: "vertexIndex"
1079210807
attributes:
1079310808
- !AttributeID "NoUnwind"
10809+
- !AttributeID "WillReturn"
1079410810
memory_effects:
1079510811
- !<MemoryRestriction>
1079610812
memory_access: !MemoryAccessType Ref
@@ -10848,6 +10864,7 @@ intrinsics:
1084810864
comment: "owordOffset"
1084910865
attributes:
1085010866
- !AttributeID "NoUnwind"
10867+
- !AttributeID "WillReturn"
1085110868
memory_effects:
1085210869
- !<MemoryRestriction>
1085310870
memory_access: !MemoryAccessType Ref
@@ -11390,6 +11407,7 @@ intrinsics:
1139011407
comment: "Unused, added for parity with GenISA_RayInfo"
1139111408
attributes:
1139211409
- !AttributeID "NoUnwind"
11410+
- !AttributeID "WillReturn"
1139311411
memory_effects:
1139411412
- !<MemoryRestriction>
1139511413
memory_access: !MemoryAccessType Ref

0 commit comments

Comments
 (0)