Skip to content

Commit 7b4058c

Browse files
sys-igcigcbot
authored andcommitted
[Autobackout][FunctionalRegression]Revert of change: 46173b7: Add a reg key to disable emulation for fp64 to fp16 conversion
This change is only to control over the emulation mask for fp64 to fp16 conversion.
1 parent 44aa331 commit 7b4058c

File tree

2 files changed

+2
-3
lines changed

2 files changed

+2
-3
lines changed

IGC/Compiler/CISACodeGen/ShaderCodeGen.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -533,7 +533,7 @@ void AddLegalizationPasses(CodeGenContext& ctx, IGCPassManager& mpm, PSSignature
533533
theEmuKind |= (hasDPDivSqrtEmu ? EmuKind::EMU_DP_DIV_SQRT : 0);
534534
theEmuKind |= (ctx.m_hasDPConvEmu ? EmuKind::EMU_DP_CONV : 0);
535535
theEmuKind |= (ctx.m_DriverInfo.NeedI64BitDivRem() ? EmuKind::EMU_I64DIVREM : 0);
536-
theEmuKind |= (ctx.m_DriverInfo.NeedFP64toFP16Conv() && IGC_IS_FLAG_DISABLED(ForceDisableDPToHFConvEmu) ? EmuKind::EMU_FP64_FP16_CONV : 0);
536+
theEmuKind |= (ctx.m_DriverInfo.NeedFP64toFP16Conv() ? EmuKind::EMU_FP64_FP16_CONV : 0);
537537
theEmuKind |=
538538
((IGC_IS_FLAG_ENABLED(ForceSPDivEmulation) ||
539539
(ctx.m_DriverInfo.NeedIEEESPDiv() && !ctx.platform.hasCorrectlyRoundedMacros()))

IGC/common/igc_flags.h

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -527,8 +527,7 @@ DECLARE_IGC_REGKEY(bool, Force32BitIntDivRemEmuSP, false, "Force 32-bit Int
527527
DECLARE_IGC_REGKEY(bool, EnableRecursionOpenCL, true, "Enable recursion with OpenCL user functions", false)
528528
DECLARE_IGC_REGKEY(bool, ForceDPEmulation, false, "Force double emulation for testing purpose", false)
529529
DECLARE_IGC_REGKEY(bool, EnableDPEmulation, false, "Enforce double precision floating point operations emulation on platforms that do not support it natively", true)
530-
DECLARE_IGC_REGKEY(bool, DPEmuNeedI64Emu, true, "Double Emulation needs I64 emulation. Unsetting it to disable I64 Emulation for testing.", false)
531-
DECLARE_IGC_REGKEY(bool, ForceDisableDPToHFConvEmu, false, "Force the compiler to disable an emulation for the conversion from fp64 to fp16 (use a native (inaccurate) operations instead - fp64 to fp32 and then fp32 to fp16)", false)
530+
DECLARE_IGC_REGKEY(bool, DPEmuNeedI64Emu, true, "Double Emulation needs I64 emulation. Unsetting it to disable I64 Emulation for testing.", false)
532531
DECLARE_IGC_REGKEY(bool, SelectiveLoopUnrollForDPEmu, true, "Setting this to 0/false disable selective loop unrolling for DP emu.", true)
533532
DECLARE_IGC_REGKEY(bool, ForceSPDivEmulation, false, "Force SP Div emulation for testing purpose", false)
534533
DECLARE_IGC_REGKEY(DWORD, ForceI64DivRemEmu, 0, "Forces specific int64 div/rem emulation: 0 = platform default, 1 = int based, 2 = SP based, 3 = DP based", false)

0 commit comments

Comments
 (0)