Skip to content

Commit 9353d62

Browse files
committed
[Autobackout][FuncReg]Revert of change: 79becf3
group instructions together for performance Change-Id: I64363cee1803608d9060607779edd5184d557d7a
1 parent 97ba419 commit 9353d62

File tree

4 files changed

+1
-68
lines changed

4 files changed

+1
-68
lines changed

visa/Gen4_IR.cpp

Lines changed: 0 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -8199,34 +8199,3 @@ G4_INST* G4_InstMath::cloneInst()
81998199
src0, src1, getMathCtrl(), option, getLineNo(), getCISAOff(), getSrcFilename());
82008200
}
82018201

8202-
8203-
bool G4_INST::isRMWCombinCandidate(G4_INST *next)
8204-
{
8205-
if (isSend() || next->isSend())
8206-
{
8207-
return false;
8208-
}
8209-
8210-
G4_Operand* dst = getDst();
8211-
G4_Operand* nextDst = next->getDst();
8212-
//The current instruction must has Integer macro dst as well
8213-
if (nextDst &&
8214-
nextDst->isGen12IntegerMacroDst() &&
8215-
dst->getType() == nextDst->getType())
8216-
{
8217-
8218-
unsigned short lastLB = (unsigned short)dst->getLinearizedStart();
8219-
unsigned short lastRB = (unsigned short)dst->getLinearizedEnd();
8220-
unsigned short nextLB = (unsigned short)nextDst->getLinearizedStart();
8221-
unsigned short nextRB = (unsigned short)nextDst->getLinearizedEnd();
8222-
8223-
if (lastLB / G4_GRF_REG_NBYTES == nextLB / G4_GRF_REG_NBYTES &&
8224-
lastRB / G4_GRF_REG_NBYTES == nextRB / G4_GRF_REG_NBYTES &&
8225-
dst->compareOperand(nextDst) == Rel_disjoint)
8226-
{
8227-
return true;
8228-
}
8229-
}
8230-
8231-
return false;
8232-
}

visa/Gen4_IR.hpp

Lines changed: 0 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -954,7 +954,6 @@ class G4_INST
954954
}
955955

956956
bool mayExpandToAccMacro() const;
957-
bool isRMWCombinCandidate(G4_INST* next);
958957

959958
Gen4_Operand_Number getSrcOperandNum(int srcPos) const
960959
{
@@ -2324,25 +2323,6 @@ class G4_Operand
23242323
return type;
23252324
}
23262325
}
2327-
bool isGen12IntegerMacroDst()
2328-
{
2329-
if (isNullReg())
2330-
{
2331-
return false;
2332-
}
2333-
2334-
if (type == Type_UW ||
2335-
type == Type_W ||
2336-
type == Type_B ||
2337-
type == Type_UB ||
2338-
type == Type_D ||
2339-
type == Type_UD)
2340-
{
2341-
return true;
2342-
}
2343-
2344-
return false;
2345-
}
23462326
};
23472327

23482328
class G4_VarBase

visa/LocalScheduler/SWSB_G4IR.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4451,6 +4451,7 @@ void G4_BB_SB::SBDDD(G4_BB* bb,
44514451
getGRFBucketDescrs(node, liveBDvec, false);
44524452
}
44534453

4454+
44544455
// For ALU instructions without GRF usage
44554456
if (distanceHonourInstruction(curInst))
44564457
{

visa/LocalScheduler/SWSB_G4IR.h

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -136,23 +136,6 @@ namespace vISA
136136

137137
void setOffset(unsigned short o) { offset = o; }
138138

139-
bool hasOverlap(SBFootprint* liveFootprint) const
140-
{
141-
SBFootprint* curFootprint2Ptr = liveFootprint;
142-
while (curFootprint2Ptr)
143-
{
144-
// Negative of no overlap: !(LeftB > curFootprint2Ptr->RightB || RightB < curFootprint2Ptr->LeftB)
145-
if (fType == curFootprint2Ptr->fType &&
146-
LeftB <= curFootprint2Ptr->RightB && RightB >= curFootprint2Ptr->LeftB)
147-
{
148-
return true;
149-
}
150-
curFootprint2Ptr = curFootprint2Ptr->next;
151-
}
152-
153-
return false;
154-
}
155-
156139
bool hasOverlap(SBFootprint *liveFootprint, unsigned short &internalOffset) const
157140
{
158141
SBFootprint *curFootprint2Ptr = liveFootprint;

0 commit comments

Comments
 (0)