Initialize variables. Reduce copying. Promote types.

Addresses Coverity issues.

Author: fda0

IGC/Compiler/CISACodeGen/IGCVectorizer.cpp

@@ -184,6 +184,8 @@ unsigned int getVectorSize(Value *I) {
 bool isFDivSafe(Instruction *I) {
     if (!IGC_GET_FLAG_VALUE(VectorizerAllowFDIV)) return false;
     auto* Binary = llvm::dyn_cast<BinaryOperator>(I);
+    if (!Binary) return false;
+
     auto OpCode = Binary->getOpcode();
     if (!(OpCode == Instruction::FDiv && I->getType()->isFloatTy())) return false;
 

IGC/Compiler/CISACodeGen/helper.cpp

@@ -3391,7 +3391,7 @@ std::vector<std::pair<unsigned int, std::string>> GetPrintfStrings(Module &M)
     {
         MDNode* argMDNode = printfMDNode->getOperand(i);
         ConstantInt* indexOpndVal =
-            mdconst::dyn_extract<ConstantInt>(argMDNode->getOperand(0));
+            mdconst::extract<ConstantInt>(argMDNode->getOperand(0));
         MDString* stringOpndVal =
             dyn_cast<MDString>(argMDNode->getOperand(1));
 

IGC/Compiler/MetaDataApi/IGCMetaDataHelper.cpp

@@ -58,8 +58,7 @@ void IGCMetaDataHelper::copyFunction(
     auto loc = FuncMD.find(OldFunc);
     if (loc != FuncMD.end())
     {
-        auto funcInfo = loc->second;
-        FuncMD[NewFunc] = funcInfo;
+        FuncMD[NewFunc] = loc->second;
     }
 }