Skip to content

Commit add198f

Browse files
pkwasnie-intelpszymich
authored andcommitted
LSCFuncsResolution pass - fail if atomic uses L1 cache
LSC atomics are always uncached in L1. Report error in LSCFuncsResolution pass for invalid caching options. (cherry picked from commit 89336c1)
1 parent ac5c776 commit add198f

File tree

2 files changed

+58
-4
lines changed

2 files changed

+58
-4
lines changed

IGC/Compiler/Optimizer/OpenCLPasses/LSCFuncs/LSCFuncsResolution.cpp

Lines changed: 20 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -497,7 +497,7 @@ Instruction* LSCFuncsResolution::CreateLSCAtomicIntrinsicCallInst(
497497
atomArg2, // value [cmpxchg] or zero if unused
498498
getConstantInt32(atomicOp), // atomic op
499499
isLocalMem ? // cache options (default for local)
500-
getConstantInt32(LSC_L1DEF_L3DEF) : getCacheControlOpts(ccOpndIx)
500+
getConstantInt32(LSC_L1DEF_L3DEF) : getCacheControlOpts(ccOpndIx, true)
501501
};
502502

503503
GenISAIntrinsic::ID id =
@@ -807,10 +807,26 @@ Constant *LSCFuncsResolution::getImmediateElementOffset(
807807
}
808808
}
809809

810-
Constant *LSCFuncsResolution::getCacheControlOpts(int i, bool)
810+
Constant *LSCFuncsResolution::getCacheControlOpts(int i, bool isAtomic)
811811
{
812-
// TODO: error if atomic uses any sort of caching on L1
813-
return getImmediateEnum(i, LSC_L1DEF_L3DEF, LSC_L1IAR_WB_L3C_WB);
812+
Constant *c = getImmediateEnum(i, LSC_L1DEF_L3DEF, LSC_L1IAR_WB_L3C_WB);
813+
814+
if (isAtomic)
815+
{
816+
ConstantInt* ci = dyn_cast<ConstantInt>(c);
817+
switch (ci->getZExtValue())
818+
{
819+
case LSC_L1DEF_L3DEF:
820+
case LSC_L1UC_L3UC:
821+
case LSC_L1UC_L3C_WB:
822+
break;
823+
default:
824+
reportError("atomic must not use caching on L1");
825+
c = getConstantInt32(LSC_L1DEF_L3DEF);
826+
}
827+
}
828+
829+
return c;
814830
}
815831

816832
void LSCFuncsResolution::reportError(const char *what) {
Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,38 @@
1+
;=========================== begin_copyright_notice ============================
2+
;
3+
; Copyright (C) 2022 Intel Corporation
4+
;
5+
; SPDX-License-Identifier: MIT
6+
;
7+
;============================ end_copyright_notice =============================
8+
;
9+
; RUN: igc_opt -enable-debugify --igc-lsc-funcs-translation -platformdg2 -S < %s 2>&1 | FileCheck %s
10+
; ------------------------------------------------
11+
; LSCFuncsResolution
12+
; ------------------------------------------------
13+
14+
; Test checks that lsc atomic can't use L1 cached option
15+
16+
; Debug-info related check
17+
; CHECK-NOT: WARNING
18+
; CHECK: CheckModuleDebugify: PASS
19+
20+
define spir_kernel void @test_lsc(i32* %base) {
21+
; CHECK-LABEL: @test_lsc(
22+
; CHECK: [[TMP:%.*]] = call i32 @llvm.genx.GenISA.LSCAtomicInts.i32.p0i32.i32.i32(i32* %base, i32 8, i32 0, i32 0, i32 2, i32 0)
23+
; CHECK: ret void
24+
;
25+
%1 = call i32 @__builtin_IB_lsc_atomic_inc_global_uint(i32* %base, i32 8, i32 4)
26+
ret void
27+
}
28+
29+
; CHECK: error: line 1: __builtin_IB_lsc_atomic_inc_global_uint: atomic must not use caching on L1
30+
31+
declare i32 @__builtin_IB_lsc_atomic_inc_global_uint(i32*, i32, i32)
32+
33+
!igc.functions = !{!0}
34+
35+
!0 = !{void (i32*)* @test_lsc, !1}
36+
!1 = !{!2, !3}
37+
!2 = !{!"function_type", i32 0}
38+
!3 = !{!"sub_group_size", i32 16}

0 commit comments

Comments
 (0)