Continue to refactor visa attribtues

Change-Id: Id1f586df081d23efcffb6e2dae2027bd66616b19

Author: jgu222

visa/Attributes.cpp

@@ -116,6 +116,25 @@ bool Attributes::isAttribute(ID aID, const char* AttrName)
 
 void Attributes::setIntKernelAttribute(Attributes::ID kID, int val)
 {
+    // Verify kernel attribute
+    switch (kID) {
+    case ATTR_SpillMemOffset :
+    {
+        assert((val & (GENX_GRF_REG_SIZ - 1)) == 0  &&
+            "Kernel attribute: SpillMemOffset is mis-aligned!");
+        break;
+    }
+    case ATTR_SimdSize :
+    {
+        // allow 0
+        assert((val == 0 || val == 8 || val == 16 || val == 32) &&
+            "Kernel attribute: SimdSize must be 0|8|16|32!");
+        break;
+    }
+    default:
+        break;
+    }
+
     m_kernelAttrs[kID].m_val.m_intVal = val;
     m_kernelAttrs[kID].m_isSet = true;
 }

visa/BuildIR.h

@@ -631,7 +631,7 @@ class IR_Builder {
     const iga::Model* getIGAModel() const { return igaModel; }
     uint32_t getPerThreadInputSize() const
     {
-        return kernel.getKernelAttrs()->getIntKernelAttribute(Attributes::ATTR_PerThreadInputSize);
+        return kernel.getIntKernelAttribute(Attributes::ATTR_PerThreadInputSize);
     }
 
     bool getHasPerThreadProlog() const { return hasPerThreadProlog; }

visa/FlowGraph.h

@@ -1521,6 +1521,10 @@ class G4_Kernel
 
     Options *getOptions(){ return m_options; }
     const Attributes* getKernelAttrs() const { return m_kernelAttrs; }
+    int getIntKernelAttribute(Attributes::ID aID) const
+    {
+        return getKernelAttrs()->getIntKernelAttribute(aID);
+    }
     bool getOption(vISAOptions opt) const { return m_options->getOption(opt); }
     void computeChannelSlicing();
     void calculateSimdSize();

visa/Optimizer.cpp

@@ -6888,7 +6888,7 @@ bool Optimizer::foldPseudoAndOr(G4_BB* bb, INST_LIST_ITER& ii)
         }
 
         if (builder.needReplaceIndirectCallWithJmpi() &&
-            kernel.getKernelAttrs()->getIntKernelAttribute(Attributes::ATTR_Extern) != 0)
+            kernel.getIntKernelAttribute(Attributes::ATTR_Extern) != 0)
         {
             // replace ret in the external functions with jmpi. That we will
             // also return the call with jmpi in VISAKernelImpl::compilePostOptimize