Skip to content

Commit bb79841

Browse files
pratikasharigcbot
authored andcommitted
Update field name and semantics of zeinfo field
Update field name and semantics of zeinfo field
1 parent 0277509 commit bb79841

File tree

4 files changed

+5
-5
lines changed

4 files changed

+5
-5
lines changed

IGC/ZEBinWriter/zebin/source/autogen/ZEInfo.hpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ struct zeInfoExecutionEnv
4747
{
4848
bool operator==(const zeInfoExecutionEnv& other) const
4949
{
50-
return barrier_count == other.barrier_count && disable_mid_thread_preemption == other.disable_mid_thread_preemption && grf_count == other.grf_count && has_4gb_buffers == other.has_4gb_buffers && has_device_enqueue == other.has_device_enqueue && has_dpas == other.has_dpas && has_fence_for_image_access == other.has_fence_for_image_access && has_global_atomics == other.has_global_atomics && has_multi_scratch_spaces == other.has_multi_scratch_spaces && has_no_stateless_write == other.has_no_stateless_write && has_stack_calls == other.has_stack_calls && require_disable_eufusion == other.require_disable_eufusion && indirect_stateless_count == other.indirect_stateless_count && inline_data_payload_size == other.inline_data_payload_size && offset_to_skip_per_thread_data_load == other.offset_to_skip_per_thread_data_load && offset_to_skip_set_ffid_gp == other.offset_to_skip_set_ffid_gp && required_sub_group_size == other.required_sub_group_size && required_work_group_size == other.required_work_group_size && simd_size == other.simd_size && slm_size == other.slm_size && private_size == other.private_size && spill_size == other.spill_size && subgroup_independent_forward_progress == other.subgroup_independent_forward_progress && thread_scheduling_mode == other.thread_scheduling_mode && work_group_walk_order_dimensions == other.work_group_walk_order_dimensions && eu_thread_count == other.eu_thread_count && has_sample == other.has_sample && has_rtcalls == other.has_rtcalls && generate_local_id == other.generate_local_id && has_lsc_stores_with_non_default_l1_cache_controls == other.has_lsc_stores_with_non_default_l1_cache_controls && implicit_arg_buffer_used_by_code == other.implicit_arg_buffer_used_by_code;
50+
return barrier_count == other.barrier_count && disable_mid_thread_preemption == other.disable_mid_thread_preemption && grf_count == other.grf_count && has_4gb_buffers == other.has_4gb_buffers && has_device_enqueue == other.has_device_enqueue && has_dpas == other.has_dpas && has_fence_for_image_access == other.has_fence_for_image_access && has_global_atomics == other.has_global_atomics && has_multi_scratch_spaces == other.has_multi_scratch_spaces && has_no_stateless_write == other.has_no_stateless_write && has_stack_calls == other.has_stack_calls && require_disable_eufusion == other.require_disable_eufusion && indirect_stateless_count == other.indirect_stateless_count && inline_data_payload_size == other.inline_data_payload_size && offset_to_skip_per_thread_data_load == other.offset_to_skip_per_thread_data_load && offset_to_skip_set_ffid_gp == other.offset_to_skip_set_ffid_gp && required_sub_group_size == other.required_sub_group_size && required_work_group_size == other.required_work_group_size && simd_size == other.simd_size && slm_size == other.slm_size && private_size == other.private_size && spill_size == other.spill_size && subgroup_independent_forward_progress == other.subgroup_independent_forward_progress && thread_scheduling_mode == other.thread_scheduling_mode && work_group_walk_order_dimensions == other.work_group_walk_order_dimensions && eu_thread_count == other.eu_thread_count && has_sample == other.has_sample && has_rtcalls == other.has_rtcalls && generate_local_id == other.generate_local_id && has_lsc_stores_with_non_default_l1_cache_controls == other.has_lsc_stores_with_non_default_l1_cache_controls && require_iab == other.require_iab;
5151
}
5252
zeinfo_int32_t barrier_count = 0;
5353
zeinfo_bool_t disable_mid_thread_preemption = false;
@@ -79,7 +79,7 @@ struct zeInfoExecutionEnv
7979
zeinfo_bool_t has_rtcalls = false;
8080
zeinfo_bool_t generate_local_id = false;
8181
zeinfo_bool_t has_lsc_stores_with_non_default_l1_cache_controls = false;
82-
zeinfo_bool_t implicit_arg_buffer_used_by_code = true;
82+
zeinfo_bool_t require_iab = false;
8383
};
8484
struct zeInfoPayloadArgument
8585
{

IGC/ZEBinWriter/zebin/source/autogen/ZEInfoYAML.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ void MappingTraits<zeInfoExecutionEnv>::mapping(IO& io, zeInfoExecutionEnv& info
8888
io.mapOptional("has_rtcalls", info.has_rtcalls, false);
8989
io.mapOptional("generate_local_id", info.generate_local_id, false);
9090
io.mapOptional("has_lsc_stores_with_non_default_l1_cache_controls", info.has_lsc_stores_with_non_default_l1_cache_controls, false);
91-
io.mapOptional("implicit_arg_buffer_used_by_code", info.implicit_arg_buffer_used_by_code, true);
91+
io.mapOptional("require_iab", info.require_iab, false);
9292
}
9393
void MappingTraits<zeInfoPayloadArgument>::mapping(IO& io, zeInfoPayloadArgument& info)
9494
{

IGC/ZEBinWriter/zebin/spec/version.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ Format: \<_Major number_\>.\<_Minor number_\>
1717

1818
## Change Note
1919
- **Version 1.55**: Internal feature.
20-
- **Version 1.54**: Add execution env flag implicit_arg_buffer_used_by_code.
20+
- **Version 1.54**: Add execution env flag require_iab.
2121
- **Version 1.53**: Internal changes.
2222
- **Version 1.52**: Add has_lsc_stores_with_non_default_l1_cache_controls flag in zeinfo environment.
2323
- **Version 1.51**: Attribute size in payload_arguments now shows the number of bytes needed for allocating the argument. It is no longer aligned to 4.

IGC/ZEBinWriter/zebin/spec/zeinfo.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ If an attribute is **Required**, it must be present in execution_env. If it's **
146146
| has_rtcalls | bool | Optional | false | |
147147
| generate_local_id | bool | Optional | false | Flag of HW local ID capable info in cross-thread-payload. |
148148
| has_lsc_stores_with_non_default_l1_cache_controls | bool | Optional | false | Flag of HasLscStoresWithNonDefaultL1CacheControls to determine if the resource barriers should flush UAV coherency. |
149-
| implicit_arg_buffer_used_by_code | bool | Optional | true | When set to false, implicit arg buffer is not used by the program. So runtime may decide to not program the buffer. However, if debugger connects, the runtime would have to program implicit arg buffer. This flag may be false only when has_stack_calls is also false. It is an error to set this flag to false when has_stack_calls is true. |
149+
| require_iab | bool | Optional | false | When set to false, implicit arg buffer is not used by the program. So runtime may decide to not program the buffer. However, if debugger connects, the runtime would have to program implicit arg buffer. This flag may be false only when has_stack_calls is also false. It is an error to explicitly set this flag to false when has_stack_calls is true. When set to true, runtime must allocate implicit arg buffer. |
150150
<!--- ExecutionEnv -->
151151

152152
### Supported thread scheduling mode:

0 commit comments

Comments
 (0)