Remove PreservesCFG flag from InsertBranchOpt pass

eternastudento · igcbot · commit bc18c0de02c6 · 2025-01-31T00:38:28.000+01:00
InsertBranchOpt pass modifies CFG therefore it should not indicate preservation
of it. Otherwise it could lead to a further crash (e.g. in code sinking).
diff --git a/IGC/Compiler/CustomSafeOptPass.cpp b/IGC/Compiler/CustomSafeOptPass.cpp
@@ -6437,7 +6437,6 @@ namespace {
         bool HasSrcFromEE(Instruction* I, uint selNum, Instruction*& loadInst);
         virtual void getAnalysisUsage(llvm::AnalysisUsage& AU) const override
         {
-            AU.setPreservesCFG();
             AU.addRequired<CodeGenContextWrapper>();
         }
     private:

Original file line number	Diff line number	Diff line change
`@@ -6437,7 +6437,6 @@ namespace {`
`6437`	`6437`	`bool HasSrcFromEE(Instruction* I, uint selNum, Instruction*& loadInst);`
`6438`	`6438`	`virtual void getAnalysisUsage(llvm::AnalysisUsage& AU) const override`
`6439`	`6439`	`{`
`6440`		`- AU.setPreservesCFG();`
`6441`	`6440`	`AU.addRequired<CodeGenContextWrapper>();`
`6442`	`6441`	`}`
`6443`	`6442`	`private:`