Refactor ZEBinary flags and documentation

Refactored all conditions based on enableZEBinary() and supportsZEBin(), as if they were always true. Removed said conditions.

Author: michalkr52

IGC/Compiler/CISACodeGen/CISABuilder.cpp

@@ -5634,8 +5634,7 @@ void CEncoder::Compile(bool hasSymbolTable, GenXFunctionGroupAnalysis *&pFGA) {
 
   createSymbolAndGlobalHostAccessTables(hasSymbolTable, *pMainKernel, pOutput->m_scratchSpaceUsedBySpills);
   createRelocationTables(*pMainKernel);
-  if (context->enableZEBinary())
-    CreateFuncAttributeTable(pMainKernel, pFGA);
+  CreateFuncAttributeTable(pMainKernel, pFGA);
 
   pOutput->m_numGRFSpillFill = jitInfo->stats.numGRFSpillFillWeighted;
 
@@ -5652,7 +5651,7 @@ void CEncoder::Compile(bool hasSymbolTable, GenXFunctionGroupAnalysis *&pFGA) {
 
   pOutput->m_perThreadArgumentStackSize = m_argumentStackSize;
 
-  if (context->enableZEBinary() && context->type == ShaderType::OPENCL_SHADER &&
+  if (context->type == ShaderType::OPENCL_SHADER &&
       IGC_IS_FLAG_ENABLED(EnableKernelCostInfo)) {
     kci = createKernelCostInfo(*pMainKernel);
   }
@@ -5710,8 +5709,6 @@ void CEncoder::createRelocationTables(VISAKernel &pMainKernel) {
 }
 
 const vISA::KernelCostInfo *CEncoder::createKernelCostInfo(VISAKernel &pMainKernel) {
-  CodeGenContext *context = m_program->GetContext();
-  IGC_ASSERT(context->enableZEBinary());
   const vISA::KernelCostInfo *KCI = nullptr;
   pMainKernel.getKernelCostInfo(KCI);
   if (!KCI) {

IGC/Compiler/CISACodeGen/EmitVISAPass.cpp

@@ -889,7 +889,7 @@ bool EmitPass::runOnFunction(llvm::Function &F) {
     auto vMod = IGC::ScalarVisaModule::BuildNew(m_currShader, Entry, IsPrimary);
     IGC::DebugEmitterOpts DebugOpts;
     DebugOpts.DebugEnabled = DebugInfoData::hasDebugInfo(m_currShader);
-    DebugOpts.ZeBinCompatible = IGC_IS_FLAG_ENABLED(ZeBinCompatibleDebugging) && m_pCtx->enableZEBinary();
+    DebugOpts.ZeBinCompatible = IGC_IS_FLAG_ENABLED(ZeBinCompatibleDebugging);
     DebugOpts.EnableRelocation = IGC_IS_FLAG_ENABLED(EnableRelocations) || DebugOpts.ZeBinCompatible;
     DebugOpts.EnforceAMD64Machine = IGC_IS_FLAG_ENABLED(DebugInfoEnforceAmd64EM) || DebugOpts.ZeBinCompatible;
     DebugOpts.EnableDebugInfoValidation = IGC_IS_FLAG_ENABLED(DebugInfoValidation);

IGC/Compiler/CISACodeGen/GenCodeGenModule.cpp

@@ -459,13 +459,12 @@ bool GenXCodeGenModule::runOnModule(Module &M) {
   // compiled once and runtime must relocate its address for each caller.
   m_FunctionCloningThreshold = 0;
   if (IGC_IS_FLAG_ENABLED(EnableFunctionCloningControl)) {
-    if (getAnalysis<CodeGenContextWrapper>().getCodeGenContext()->enableZEBinary()) {
-      // Avoid cloning by default on zebin
-      m_FunctionCloningThreshold = 1;
-    }
     if (IGC_GET_FLAG_VALUE(FunctionCloningThreshold) != 0) {
       // Overwrite with debug flag
       m_FunctionCloningThreshold = IGC_GET_FLAG_VALUE(FunctionCloningThreshold);
+    } else {
+      // Avoid cloning by default on zebin
+      m_FunctionCloningThreshold = 1;
     }
   }
 

IGC/Compiler/CISACodeGen/OpenCLKernelCodeGen.hpp

@@ -65,7 +65,6 @@ class OpenCLProgramContext : public CodeGenContext {
 
   }
 
-  bool enableZEBinary() const override { return true; }
   bool isSPIRV() const;
   void setAsSPIRV();
   float getProfilingTimerResolution();

IGC/Compiler/CISACodeGen/Platform.hpp

@@ -556,19 +556,6 @@ class CPlatform {
     return m_platformInfo.eRenderCoreFamily == IGFX_XE_HPC_CORE && IGC_IS_FLAG_ENABLED(EnableQWRotateInstructions);
   }
 
-  bool supportsZEBin() const {
-    switch (m_platformInfo.eProductFamily) {
-    default:
-      return true;
-    case IGFX_BROADWELL:
-    case IGFX_BROXTON:
-    case IGFX_GEMINILAKE:
-    case IGFX_LAKEFIELD:
-    case IGFX_ELKHARTLAKE:
-      return false;
-    }
-  }
-
   bool isIntegratedGraphics() const {
     switch (m_platformInfo.eProductFamily) {
     case IGFX_DG1:

IGC/Compiler/CISACodeGen/helper.cpp

@@ -3026,9 +3026,6 @@ bool AllowShortImplicitPayloadHeader(const CodeGenContext *ctx) {
   if (value != TriboolFlag::Default)
     return value == TriboolFlag::Enabled;
 
-  if (!ctx->platform.supportsZEBin())
-    return false;
-
   if (ctx->type == ShaderType::OPENCL_SHADER) {
     auto *OCLCtx = static_cast<const OpenCLProgramContext *>(ctx);
     if (OCLCtx->m_InternalOptions.PromoteStatelessToBindless && OCLCtx->m_InternalOptions.UseBindlessLegacyMode)
@@ -3047,9 +3044,6 @@ bool AllowRemovingUnusedImplicitArguments(const CodeGenContext *ctx) {
   if (value != TriboolFlag::Default)
     return value == TriboolFlag::Enabled;
 
-  if (!ctx->platform.supportsZEBin())
-    return false;
-
   if (ctx->type == ShaderType::OPENCL_SHADER) {
     auto *OCLCtx = static_cast<const OpenCLProgramContext *>(ctx);
     if (OCLCtx->m_InternalOptions.PromoteStatelessToBindless && OCLCtx->m_InternalOptions.UseBindlessLegacyMode)

IGC/Compiler/CodeGenContext.cpp

@@ -699,8 +699,6 @@ int32_t CodeGenContext::getNumThreadsPerEU() const { return -1; }
 
 uint32_t CodeGenContext::getExpGRFSize() const { return 0; }
 
-bool CodeGenContext::enableZEBinary() const { return false; }
-
 /// parameter "returnDefault" controls what to return when
 /// there is no user-forced setting
 uint32_t CodeGenContext::getNumGRFPerThread(bool returnDefault) {

IGC/Compiler/CodeGenPublic.h

@@ -1033,7 +1033,6 @@ class CodeGenContext {
   virtual int16_t getVectorCoalescingControl() const;
   virtual uint32_t getPrivateMemoryMinimalSizePerThread() const;
   virtual uint32_t getIntelScratchSpacePrivateMemoryMinimalSizePerThread() const;
-  virtual bool enableZEBinary() const;
   bool isPOSH() const;
   virtual bool isBufferBoundsChecking() const;
   virtual uint64_t getMinimumValidAddress() const;

IGC/VISALinkerDriver/VLD.cpp

@@ -292,7 +292,6 @@ using namespace TC;
 //
 // Assumptions:
 // 1. ZEBinary output format is used in SPMD+ESIMD case.
-// TODO: error out if patch token output format is used.
 bool TranslateBuildSPMDAndESIMD(const TC::STB_TranslateInputArgs *pInputArgs, TC::STB_TranslateOutputArgs *pOutputArgs,
                                 TC::TB_DATA_FORMAT inputDataFormatTemp, const IGC::CPlatform &IGCPlatform,
                                 float profilingTimerResolution, const ShaderHash &inputShHash,

IGC/common/igc_flags.h

@@ -540,7 +540,7 @@ DECLARE_IGC_REGKEY(
     "Enable Stateless To Stateful transformation for global and constant address space in OpenCL kernels", false)
 DECLARE_IGC_REGKEY(
     bool, EnableStatefulToken, true,
-    "Enable generating patch token to indicate a ptr argument is fully converted to stateful (temporary)", false)
+    "Enable to indicate ptr arguments are fully converted to stateful (temporary)", false)
 DECLARE_IGC_REGKEY(bool, DisableConstBaseGlobalBaseArg, false,
                    "Do no generate kernel implicit arguments: constBase and globalBase", false)
 DECLARE_IGC_REGKEY(bool, EnableGenUpdateCB, false, "Enable derived constant optimization.", false)