Skip to content

Commit d586ab2

Browse files
fda0igcbot
authored andcommitted
Initialize CShader members, use std::move
Coverity related fixes. Initialize members, use std::move.
1 parent 502dea5 commit d586ab2

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

IGC/Compiler/CISACodeGen/CShaderProgram.hpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ namespace IGC
3636
CodeGenContext* GetContext() { return m_context; }
3737

3838
llvm::Function* getLLVMFunction() const { return m_kernel; }
39-
ShaderStats* m_shaderStats;
39+
ShaderStats* m_shaderStats = nullptr;
4040

4141
// invoked to clear Func ptr when the current module is deleted (so is func within it).
4242
void clearBeforeRetry();
@@ -51,8 +51,8 @@ namespace IGC
5151
CShader*& GetShaderPtr(SIMDMode simd, ShaderDispatchMode mode);
5252
CShader* CreateNewShader(SIMDMode simd);
5353

54-
CodeGenContext* m_context;
55-
llvm::Function* m_kernel;
54+
CodeGenContext* m_context = nullptr;
55+
llvm::Function* m_kernel = nullptr;
5656
std::array<CShader*, 9> m_SIMDshaders;
5757

5858
public:

IGC/Compiler/CISACodeGen/IGCVectorizer.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -67,7 +67,7 @@ class IGCVectorizer : public llvm::FunctionPass {
6767
std::unique_ptr<std::ofstream> OutputLogFile;
6868
std::string LogStr;
6969
llvm::raw_string_ostream OutputLogStream = raw_string_ostream(LogStr);
70-
Module* M;
70+
Module* M = nullptr;
7171
void initializeLogFile(Function& F);
7272
void writeLog();
7373

IGC/Compiler/CISACodeGen/ShaderCodeGen.hpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -392,11 +392,11 @@ class CShader
392392

393393
ModuleMetaData* m_ModuleMetadata = nullptr;
394394
/// SIMD Size is the default size of instructions
395-
ShaderDispatchMode m_ShaderDispatchMode;
395+
ShaderDispatchMode m_ShaderDispatchMode{};
396396
/// the default emit size for this shader. This is the default size for variables as well
397397
/// as the default execution size for each instruction. encoder may override it explicitly
398398
/// via CEncoder::SetSIMDSize
399-
SIMDMode m_SIMDSize;
399+
SIMDMode m_SIMDSize{};
400400
uint8_t m_numberInstance = 0;
401401
PushInfo pushInfo;
402402
EmitPass* m_EmitPass = nullptr;
@@ -696,7 +696,7 @@ class CShader
696696
std::vector<CVariable*> patchConstantSetup;
697697
std::vector<CVariable*> perPrimitiveSetup;
698698

699-
uint m_maxBlockId;
699+
uint m_maxBlockId = 0;
700700

701701
CVariable* m_R0 = nullptr;
702702
CVariable* m_NULL = nullptr;

0 commit comments

Comments
 (0)