enable implicit args optimizations by default

Enables implicit args optimizations (ShortImplicitPayloadHeader,
RemoveUnusedIdImplicitArguments) by default.

Author: pkwasnie-intel

IGC/Compiler/CISACodeGen/Platform.hpp

@@ -1919,6 +1919,9 @@ bool allowRemovingUnusedImplicitArguments() const
     if (IGC_IS_FLAG_SET(RemoveUnusedIdImplicitArguments))
         return IGC_IS_FLAG_ENABLED(RemoveUnusedIdImplicitArguments);
 
+    if (!supportsZEBin())
+        return false;
+
     return isCoreChildOf(IGFX_XE_HP_CORE);
 }
 

IGC/common/igc_flags.h

@@ -943,8 +943,8 @@ DECLARE_IGC_REGKEY_ENUM(SupportUniformPrivateMemorySpace, -1, \
     " 0 - force disabled" \
     " 1 - force enabled", \
     TRIBOOL_OPTIONS, true)
-DECLARE_IGC_REGKEY(bool, ShortImplicitPayloadHeader, false, "Replaces implicit kernel argument 8xi32 payloadHeader with 3xi32 globalOffset", true)
-DECLARE_IGC_REGKEY(bool, RemoveUnusedIdImplicitArguments, false, "Remove implicit arguments: global_id_offset (payloadHeader) and/or enqueued_local_size if unused. " \
+DECLARE_IGC_REGKEY(bool, ShortImplicitPayloadHeader, true, "Replaces implicit kernel argument 8xi32 payloadHeader with 3xi32 globalOffset", true)
+DECLARE_IGC_REGKEY(bool, RemoveUnusedIdImplicitArguments, true, "Remove implicit arguments: global_id_offset (payloadHeader) and/or enqueued_local_size if unused. " \
     "Useful if kernel doesn't use global id.", true)
 
 DECLARE_IGC_GROUP("Generating precompiled headers")

IGC/ocloc_tests/features/constant_buffer/noinline.cl

@@ -11,8 +11,8 @@ SPDX-License-Identifier: MIT
 // Verify that implicit kernel arguments are not removed for kernels with subroutines.
 // Arguments can be removed for stackcalls.
 
-// RUN: ocloc compile -file %s -device pvc -options "-cl-std=CL2.0 -igc_opts 'EnableStackCallFuncCall=0, RemoveUnusedIdImplicitArguments=1, ShortImplicitPayloadHeader=1, DumpZEInfoToConsole=1'" 2>&1 | FileCheck %s --check-prefix=CHECK-SUBROUTINE
-// RUN: ocloc compile -file %s -device pvc -options "-cl-std=CL2.0 -igc_opts 'EnableStackCallFuncCall=1, RemoveUnusedIdImplicitArguments=1, ShortImplicitPayloadHeader=1, DumpZEInfoToConsole=1'" 2>&1 | FileCheck %s --check-prefix=CHECK-STACKCALL
+// RUN: ocloc compile -file %s -device pvc -options "-cl-std=CL2.0 -igc_opts 'EnableStackCallFuncCall=0, ShortImplicitPayloadHeader=1, DumpZEInfoToConsole=1'" 2>&1 | FileCheck %s --check-prefix=CHECK-SUBROUTINE
+// RUN: ocloc compile -file %s -device pvc -options "-cl-std=CL2.0 -igc_opts 'EnableStackCallFuncCall=1, ShortImplicitPayloadHeader=1, DumpZEInfoToConsole=1'" 2>&1 | FileCheck %s --check-prefix=CHECK-STACKCALL
 
 // CHECK-SUBROUTINE:      name:            kernel_that_must_have_args
 // CHECK-SUBROUTINE:        payload_arguments: