Handle missing single quotes for -igc_opts.

In igc_ocl_tranlation_ctx_impl there is handling of -igc_opts passed to
ocloc. The implementation however doesn't handle improper format, which
results in an infinite loop in case no single quotes were provided, or
the second single quote is missing.

This commit adds handling of these cases.

Author: smilczek

IGC/AdaptorOCL/ocl_igc_interface/impl/igc_ocl_translation_ctx_impl.h

@@ -256,12 +256,14 @@ CIF_DECLARE_INTERFACE_PIMPL(IgcOclTranslationCtx) : CIF::PimplBase {
 
         std::size_t foundFirstSingleQuote = optionsWithFlags.find('\'', found);
         std::size_t foundSecondSingleQuote = optionsWithFlags.find('\'', foundFirstSingleQuote + 1);
-        if (foundFirstSingleQuote != std::string::npos && foundSecondSingleQuote) {
-          RegKeysFlagsFromOptions +=
-              optionsWithFlags.substr(foundFirstSingleQuote + 1, (foundSecondSingleQuote - foundFirstSingleQuote - 1));
-          RegKeysFlagsFromOptions = RegKeysFlagsFromOptions + ',';
-          optionsWithFlags = optionsWithFlags.substr(foundSecondSingleQuote + 1, optionsWithFlags.length());
+        if (foundFirstSingleQuote == std::string::npos || foundSecondSingleQuote == std::string::npos) {
+          outputInterface->GetImpl()->SetError(TranslationErrorType::Unused, "Missing single quotes for -igc_opts");
+          return outputInterface.release();
         }
+        RegKeysFlagsFromOptions +=
+            optionsWithFlags.substr(foundFirstSingleQuote + 1, (foundSecondSingleQuote - foundFirstSingleQuote - 1));
+        RegKeysFlagsFromOptions = RegKeysFlagsFromOptions + ',';
+        optionsWithFlags = optionsWithFlags.substr(foundSecondSingleQuote + 1, optionsWithFlags.length());
       }
     }
     bool RegFlagNameError = 0;

IGC/ocloc_tests/Options/igc_opts_single_quotes.cl

@@ -0,0 +1,7 @@
+// REQUIRES: regkeys, dg2-supported
+
+// RUN: ocloc compile -file %s -options " -igc_opts 'DumpVISAASMToConsole=1" -device dg2 | FileCheck %s
+
+// XFAIL: *
+// CHECK: Missing single quotes for -igc_opts
+__kernel void foo(int a, int b, __global int *res) { *res = a + b; }