Coverity fixes

Coverity fixes

Author: amielcza

IGC/Compiler/CISACodeGen/EmitVISAPass.cpp

@@ -3311,7 +3311,7 @@ void EmitPass::EmitSelectStruct(SelectInst* SI)
         std::make_tuple(srcFalseV, srcFalseS, true)
     };
 
-    for (auto [srcV, srcS, inv] : iterator)
+    for (auto& [srcV, srcS, inv] : iterator)
     {
         // For now, do not support uniform dst and non-uniform src
         IGC_ASSERT_MESSAGE(!srcS->IsUniform() || srcS->IsUniform() == destS->IsUniform(),

IGC/Compiler/CISACodeGen/VectorShuffleAnalysis.hpp

@@ -40,8 +40,8 @@ class DestVector {
     DestVector(llvm::Value *SourceVec, llvm::InsertElementInst *DestVec, std::vector<int> ShuffleMask,
         std::vector<llvm::InsertElementInst *> IEs, std::vector<llvm::ExtractElementInst *> EEs,
         std::vector<llvm::Value *> SourceScalars)
-        : SourceVec(SourceVec), DestVec(DestVec), ShuffleMask(ShuffleMask), IEs(IEs), EEs(EEs),
-          SourceScalars(SourceScalars){};
+        : SourceVec(SourceVec), DestVec(DestVec), ShuffleMask(std::move(ShuffleMask)), IEs(std::move(IEs)), EEs(std::move(EEs)),
+          SourceScalars(std::move(SourceScalars)){};
 
     llvm::Value *SourceVec;
     llvm::InsertElementInst *DestVec; // first IE that creates a new vec (writes to Undef)
@@ -92,7 +92,7 @@ class DestVector {
 class VectorToScalarsPattern {
   public:
     VectorToScalarsPattern(llvm::Value *SourceVec, std::vector<llvm::ExtractElementInst *> EEs, bool AllUsesAreScalars)
-        : SourceVec(SourceVec), EEs(EEs), AllUsesAreScalars(AllUsesAreScalars){};
+        : SourceVec(SourceVec), EEs(std::move(EEs)), AllUsesAreScalars(AllUsesAreScalars){};
 
     bool areAllUsesScalars() const { return AllUsesAreScalars; }
 

IGC/Compiler/Optimizer/OCLBIUtils.h

@@ -278,7 +278,7 @@ namespace IGC
         llvm::Value* CoordY;
         llvm::Value* CoordZ;
         bool m_IncorrectBti;
-        ModuleMetaData* m_modMD;
+        ModuleMetaData* m_modMD = nullptr;
     };
 
     class CBuiltinsResolver

IGC/Compiler/Optimizer/OpenCLPasses/ManageableBarriers/ManageableBarriersResolution.cpp

@@ -540,12 +540,12 @@ bool ManageableBarriersResolution::runOnModule(Module& M)
                 }
 
                 // In first place, take care of the init functions
-                for (auto pair : mManageBarrierInstructionsInit)
+                for (auto& pair : mManageBarrierInstructionsInit)
                 {
                     emitInit(pair.first);
                 }
                 // Now, we can take the rest of the API calls
-                for (auto pair : mManageBarrierInstructions)
+                for (auto& pair : mManageBarrierInstructions)
                 {
                     emit(pair.first, pair.second);
                 }
@@ -639,7 +639,7 @@ bool ManageableBarriersResolution::hasSimpleCallsOnly(CallInst* pFunc)
 
 void ManageableBarriersResolution::lookForSimpleBarriers()
 {
-    for (auto init : mManageBarrierInstructionsInit)
+    for (auto& init : mManageBarrierInstructionsInit)
     {
         CallInst* pFunc = init.first;
         if (mCurrentMode == MBMode::SimpleOnly ||
@@ -693,12 +693,12 @@ ManageableBarriersResolution::SimpleBarrierStruct& ManageableBarriersResolution:
 
 void ManageableBarriersResolution::clearData()
 {
-    for (auto call : mManageBarrierInstructions)
+    for (auto& call : mManageBarrierInstructions)
     {
         call.first->eraseFromParent();
     }
 
-    for (auto init : mManageBarrierInstructionsInit)
+    for (auto& init : mManageBarrierInstructionsInit)
     {
         init.first->eraseFromParent();
     }

IGC/Compiler/Optimizer/OpenCLPasses/ManageableBarriers/ManageableBarriersResolution.hpp

@@ -77,7 +77,7 @@ namespace IGC
         llvm::DenseMap<llvm::CallInst*, MBFuncType> mManageBarrierInstructions;
         llvm::DenseMap<llvm::CallInst*, MBFuncType> mManageBarrierInstructionsInit;
         llvm::DenseMap<llvm::CallInst*, SimpleBarrierStruct> mManageBarrierInstructionsInitSimple;
-        int mSimpleBarrierIDCount;
+        int mSimpleBarrierIDCount = 0;
 
         llvm::DenseMap<llvm::Function*, llvm::Value*> mGlobalDataPoolPerFunc;
         llvm::DenseMap<llvm::Function*, llvm::Value*> mGlobalIDPoolPPerFunc;

IGC/Compiler/Optimizer/OpenCLPasses/SplitStructurePhisPass/SplitStructurePhisPass.cpp

@@ -83,7 +83,7 @@ bool SplitStructurePhisPass::runOnFunction(Function &F) {
     // 2. create new phis for each scalar types
     // 3. save dead instructions for removal
     // 4. update incoming phis incoming values
-    for (auto PhiPair : PhiNodes) {
+    for (auto& PhiPair : PhiNodes) {
         PHINode *OldPhi = PhiPair.first;
         auto Indices = std::get<0>(PhiPair.second);
         ExtractValueMap ExtractValues = std::get<1>(PhiPair.second);

IGC/Compiler/Optimizer/PromoteToPredicatedMemoryAccess.cpp

@@ -188,7 +188,7 @@ bool PromoteToPredicatedMemoryAccess::trySingleBlockIfConv(Value &Cond, BasicBlo
                     << "  ConvBB: " << ConvBB << "\n"
                     << "  SuccBB: " << SuccBB << "\n");
 
-  for (auto [Inst, MergeV] : Insts) {
+  for (auto& [Inst, MergeV] : Insts) {
     LLVM_DEBUG(dbgs() << "Converting instruction: " << *Inst << "\n");
     convertMemoryAccesses(Inst, MergeV, &Cond, Inverse);
   }