Skip to content

Commit f975ac6

Browse files
weiyu-chensys_zuul
authored andcommitted
Update max vISA variable size to be based on register size.
Change-Id: I2f0a054637095879ed6544d46fc6831bdc183f02
1 parent 8e150f6 commit f975ac6

File tree

2 files changed

+4
-32
lines changed

2 files changed

+4
-32
lines changed

visa/Common_ISA.h

Lines changed: 4 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -48,39 +48,21 @@ class G4_Declare;
4848
#define COMMON_ISA_MAJOR_VER 3
4949
#define COMMON_ISA_MINOR_VER 6
5050

51-
5251
#define COMMON_ISA_MAX_ADDRESS_SIZE 16
5352
#define COMMON_ISA_MAX_SURFACE_SIZE 128
5453
#define COMMON_ISA_MAX_SAMPLER_SIZE 128
55-
#define COMMON_ISA_MAX_VARIABLE_SIZE 8192
54+
#define COMMON_ISA_MAX_VARIABLE_SIZE (256 * getGRFSize())
5655
#define COMMON_ISA_MAX_NUM_SURFACES 256
5756
#define COMMON_ISA_MAX_NUM_SAMPLERS 32
5857
#define COMMON_ISA_MAX_NUM_INPUTS 256
5958

60-
#define COMMON_ISA_MAX_NUM_KERNELS 512
61-
#define COMMON_ISA_MAX_NUM_EXTERN_FUNCS 512
62-
#define COMMON_ISA_MAX_NUM_GLOBAL_FUNCS 512
63-
#define COMMON_ISA_MAX_NUM_STATIC_FUNCS 512
64-
#define COMMON_ISA_MAX_NUM_FUNCS \
65-
COMMON_ISA_MAX_NUM_EXTERN_FUNCS+COMMON_ISA_MAX_NUM_GLOBAL_FUNCS+COMMON_ISA_MAX_NUM_STATIC_FUN
66-
#define COMMON_ISA_MAX_NUM_EXTERN_VARS 16384
67-
#define COMMON_ISA_MAX_NUM_GLOBAL_VARS 16384
68-
#define COMMON_ISA_MAX_NUM_STATIC_VARS 16384
69-
// max number of global variables
70-
#define COMMON_ISA_MAX_NUM_VARS \
71-
COMMON_ISA_MAX_NUM_EXTERN_VARS+COMMON_ISA_MAX_NUM_GLOBAL_VARS+COMMON_ISA_MAX_NUM_STATIC_VARS;
72-
73-
// CISA3+: V0-V31 are reserved
59+
// V0-V31 are reserved
7460
#define COMMON_ISA_NUM_PREDEFINED_VAR_VER_3 32
7561
// reserve p0 for the case of no predication
7662
#define COMMON_ISA_NUM_PREDEFINED_PRED 1
77-
// CISA2.0: T0 is reserved to present SLM access
78-
#define COMMON_ISA_NUM_PREDEFINED_SURF_VER_2 1
79-
#define COMMON_ISA_NUM_PREDEFINED_SURF_VER_2_1 5
80-
#define COMMON_ISA_NUM_PREDEFINED_SURF_VER_3_1 6
8163

82-
//Max number of kernels in a common isa file
83-
#define MAX_NUM_KERNELS 512
64+
// Reserve T0-T5 as special surfaces
65+
#define COMMON_ISA_NUM_PREDEFINED_SURF_VER_3_1 6
8466

8567
// bfi can have 7 operands
8668
#define COMMON_ISA_MAX_NUM_OPND_ARITH_LOGIC 7
@@ -93,11 +75,9 @@ class G4_Declare;
9375

9476
#define COMMON_ISA_GRF_REG_SIZE (getGRFSize()) /// # of bytes in a CISA GRF register
9577

96-
#define COMMON_ISA_MAX_ADDRREG_WIDTH 8
9778
#define COMMON_ISA_MAX_FILENAME_LENGTH 1023
9879

9980
#define COMMON_ISA_MAX_KERNEL_NAME_LEN 255
100-
#define COMMON_ISA_MAX_ADDRESS_OFFSET 4096
10181

10282
#define SEND_GT_MSG_TYPE_BIT 14
10383
#define SEND_GT_MSG_LENGTH_BIT_OFFSET 25
@@ -730,8 +710,6 @@ typedef struct _CISA_INST
730710
char* inline_cisa; /// Just a pointer to a char buffer containing inline cisa isaasm.
731711
} CISA_INST;
732712

733-
//Max number of kernels in a common isa file
734-
#define MAX_NUM_KERNELS 512
735713
#define READ_FIELD_FROM_BUF( dst, type ) \
736714
dst = *((type *) &buf[byte_pos]); \
737715
byte_pos += sizeof(type);

visa/Common_ISA_framework.h

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -51,12 +51,6 @@ SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
5151

5252
// reserve p0 for the case of no predication
5353
#define COMMON_ISA_NUM_PREDEFINED_PRED 1
54-
// reserve t0 for SLM access
55-
#define COMMON_ISA_NUM_PREDEFINED_SURF COMMON_ISA_NUM_PREDEFINED_SURF_VER_2
56-
// T0-T4
57-
#define COMMON_ISA_NUM_PREDEFINED_SURF_2_1 COMMON_ISA_NUM_PREDEFINED_SURF_VER_2_1
58-
// add T5 (stateless)
59-
#define COMMON_ISA_NUM_PREDEFINED_SURF_3_1 COMMON_ISA_NUM_PREDEFINED_SURF_VER_3_1
6054

6155
#if 0
6256
#define DEBUG_PRINT_SIZE(msg, value) {std::cout<< msg << value << std::endl; }

0 commit comments

Comments
 (0)