Skip to content

Commit 0317e1f

Browse files
committed
move fp8 regression fix to materialize block ptr
1 parent bb5dc8f commit 0317e1f

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

third_party/intel/lib/TritonIntelGPUTransforms/MaterializeBlockPointer.cpp

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,11 @@ struct TritonIntelGPUMaterializeBlockPointerPass
7171
return;
7272
}
7373

74+
if (fastChangeDim == rank - 2 && tensorType.getElementTypeBitWidth() == 8) {
75+
// TODO: column major layout w/ fp8 has performance regression
76+
return;
77+
}
78+
7479
if (fastChangeDim >= (rank - 2)) {
7580
// HW 2D block read instruction only supports contiguous access.
7681
Value fastChangeStride = strides[fastChangeDim];

third_party/intel/lib/TritonIntelGPUTransforms/RewriteTensorPointer.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ bool shouldRemove(tt::MakeTensorPtrOp &op, const bool isUsedByStoreOp,
5151

5252
LDBG("hasDotDpasEncoding: " << ttgi::hasDotDpasEncoding(tensorType));
5353
LDBG("hasDpasEncoding: " << ttgi::hasDpasEncoding(tensorType));
54-
if (ttgi::hasDotDpasEncoding(tensorType) || isUsedByBlockLoadOp || (isUsedByStoreOp && ttgi::hasDpasEncoding(tensorType))) {
54+
if (/*ttgi::hasDotDpasEncoding(tensorType) ||*/ isUsedByBlockLoadOp || (isUsedByStoreOp && ttgi::hasDpasEncoding(tensorType))) {
5555
LDBG("Tensor has DPAS layout or is used by load/store op with DPAS layout, "
5656
"skipping removal");
5757
return false;

0 commit comments

Comments
 (0)