Skip to content

Commit 0591b37

Browse files
authored
Don't specify -A x64 option and reuse cmake build type config for Windows (#5014)
The `-A` argument is not compatible with the Ninja generator. Signed-off-by: Anatoly Myachev <[email protected]>
1 parent cfddb09 commit 0591b37

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

python/setup.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -429,12 +429,10 @@ def build_extension(self, ext):
429429
cfg = get_build_type()
430430
build_args = ["--config", cfg]
431431

432+
cmake_args += [f"-DCMAKE_BUILD_TYPE={cfg}"]
432433
if platform.system() == "Windows":
433434
cmake_args += [f"-DCMAKE_RUNTIME_OUTPUT_DIRECTORY_{cfg.upper()}={extdir}"]
434-
if sys.maxsize > 2**32:
435-
cmake_args += ["-A", "x64"]
436435
else:
437-
cmake_args += ["-DCMAKE_BUILD_TYPE=" + cfg]
438436
max_jobs = os.getenv("MAX_JOBS", str(2 * os.cpu_count()))
439437
build_args += ['-j' + max_jobs]
440438

0 commit comments

Comments
 (0)