Address code review comments

Signed-off-by: Tiotto, Ettore <[email protected]>

Author: etiotto

python/test/unit/language/test_core.py

@@ -3440,11 +3440,11 @@ def test_scaled_dot(M, N, K, col_a, col_b, rhs_scale, normal_type, mxfp_type, nu
             pytest.skip(f"scaled_dot({normal_type}, {mxfp_type}) only implemented for MI300")
         if mma == 16 and K == 64:
             pytest.skip(f"K == {K} too small for mfma {mma} in scaled_dot")
-
-    # FIXME
     if is_xpu():
-        if M == 128 and N == 128 and K == 64 and col_a == False and col_b == False and rhs_scale == True and normal_type == "e4m3" and mxfp_type == "bf16":
-            pytest.skip(f"FIXME: {M}x{N}x{K} col_a={col_a} col_b={col_b} rhs_scale={rhs_scale} normal_type={normal_type} mxfp_type={mxfp_type}")
+        if M == 128 and N == 128 and K == 64 and not col_a and not col_b and rhs_scale and normal_type == "e4m3" and mxfp_type == "bf16":
+            pytest.skip(
+                f"FIXME: {M}x{N}x{K} col_a={col_a} col_b={col_b} rhs_scale={rhs_scale} normal_type={normal_type} mxfp_type={mxfp_type}"
+            )
 
     @triton.jit
     def dot_scale_kernel(a_base, stride_a0, stride_a1, a_scale, b_base, stride_b0, stride_b1, b_scale, out,

third_party/intel/lib/TritonIntelGPUToLLVM/UpcastMXFPToLLVM.cpp

@@ -9,7 +9,6 @@
 #include "triton/Dialect/Triton/IR/Dialect.h"
 #include "llvm/ADT/STLExtras.h"
 #include "llvm/ADT/SmallVector.h"
-#include <array>
 
 using namespace mlir;
 using namespace mlir::triton;