Virtual classes need a virtual destructor (#6934)

vwbaker · web-flow · commit 0c247e1bf399 · 2025-05-26T20:49:16.000Z
See https://en.cppreference.com/w/cpp/language/destructor#Virtual_destructors This can trigger undefined behavior.
diff --git a/third_party/nvidia/hopper/lib/Transforms/WarpSpecialization/CodePartitionUtility.h b/third_party/nvidia/hopper/lib/Transforms/WarpSpecialization/CodePartitionUtility.h
@@ -28,6 +28,7 @@ struct Channel {
   bool operator==(const Channel &c) {
     return relation == c.relation && operandIdx == c.operandIdx && op == c.op;
   }
+  virtual ~Channel() = default;
 
   Operation *getDstOp() { return op; }
   unsigned getDstOperandIdx() { return operandIdx; }

Original file line number	Diff line number	Diff line change
`@@ -28,6 +28,7 @@ struct Channel {`
`28`	`28`	`bool operator==(const Channel &c) {`
`29`	`29`	`return relation == c.relation && operandIdx == c.operandIdx && op == c.op;`
`30`	`30`	`}`
	`31`	`+ virtual ~Channel() = default;`
`31`	`32`
`32`	`33`	`Operation *getDstOp() { return op; }`
`33`	`34`	`unsigned getDstOperandIdx() { return operandIdx; }`