Skip to content

Commit 209c200

Browse files
authored
Remove unnecessary dependence (#8296)
We identified unnecessary dependencies in the tests for Proton and the AMD analysis pass. Specifically, the `third_party/amd` directory is processed in CMake (line 204 of the root CMakeLists.txt) before the `triton_libs` variable is set at line 214. As a result, when the target `TritonAMDGPUTestAnalysis` accesses `triton_libs`, it resolves to an empty string, which seems to be a bug. We’ve verified that whenever these two MLIR libraries are used, specifically in `bin/CMakeLists.txt`, the corresponding targets are always linked to `triton_libs`. Therefore, it's safe to remove the explicit linkage to `triton_libs` in `TritonTestProton` and `TritonAMDGPUTestAnalysis`, as it is redundant.
1 parent 22b1a44 commit 209c200

File tree

2 files changed

+0
-2
lines changed

2 files changed

+0
-2
lines changed

test/lib/Proton/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,5 +3,4 @@ add_mlir_library(TritonTestProton
33

44
LINK_LIBS PUBLIC
55
MLIRPass
6-
${triton_libs}
76
)

third_party/amd/test/lib/Analysis/CMakeLists.txt

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,5 +12,4 @@ add_mlir_library(TritonAMDGPUTestAnalysis
1212

1313
LINK_LIBS PUBLIC
1414
MLIRPass
15-
${triton_libs}
1615
)

0 commit comments

Comments
 (0)