Merge branch 'main' into fix/try-disabling-fp64-patch

Author: kwasd

.github/WINDOWS.md

@@ -157,14 +157,14 @@ python -c 'import torch;print(torch.__version__)'
 Install build dependencies:
 
 ```
-pip install -U wheel pybind11 cython cmake 'setuptools>=65.6.1'
+pip install -U wheel pybind11 cython cmake
 ```
 
 Build and install Triton:
 
 ```
 cd python
-pip install -v --no-build-isolation '.[build,tests,tutorials]'
+pip install -v '.[build,tests,tutorials]'
 cd ..
 ```
 

.github/actions/setup-pytorch/action.yml

@@ -88,7 +88,7 @@ runs:
       uses: ./.github/actions/load
       env:
         # Increase this value to reset cache
-        CACHE_NUMBER: 15
+        CACHE_NUMBER: 16
       with:
         path: pytorch
         key: pytorch-$PYTORCH_CACHE_KEY-$CACHE_NUMBER
@@ -128,8 +128,11 @@ runs:
 
         cd pytorch
         pip install wheel
+        # FIXME: Compatibility with versions of CMake older than 3.5 has been removed, this brakes compilation of third_party/protobuf:
+        # CMake Error at third_party/protobuf/cmake/CMakeLists.txt:2 (cmake_minimum_required)
+        pip install 'cmake<4.0.0'
         pip install -r requirements.txt
-        USE_STATIC_MKL=1 CFLAGS="-Wno-error=maybe-uninitialized" python setup.py bdist_wheel 2>&1 | grep -v \
+        USE_XCCL=1 USE_STATIC_MKL=1 CFLAGS="-Wno-error=maybe-uninitialized" python setup.py bdist_wheel 2>&1 | grep -v \
           "Double arithmetic operation is not supported on this platform with FP64 conversion emulation mode (poison FP64 kernels is enabled)." | grep -v '^$'
 
     - name: Install PyTorch (built from source)

.github/actions/setup-triton/action.yml

@@ -13,7 +13,7 @@ inputs:
     default: "false"
   command:
     description: Command to execute
-    default: DEBUG=1 pip install -v --no-build-isolation '.[build,tests,tutorials]'
+    default: DEBUG=1 pip install -v '.[build,tests,tutorials]'
 runs:
   using: "composite"
   steps:

.github/workflows/build-test-reusable.yml

@@ -74,6 +74,7 @@ env:
 jobs:
   integration-tests:
     name: Integration tests
+    timeout-minutes: 720
     runs-on: ${{ fromJson(inputs.runner_label && format('["linux", "{0}"]', inputs.runner_label) || format('["linux", "{0}", "{1}", "{2}"]', inputs.device, inputs.driver_version, inputs.runner_version)) }}
     defaults:
       run:
@@ -131,27 +132,53 @@ jobs:
           build_llvm: ${{ inputs.build_llvm }}
           use_spirv_backend: ${{ inputs.use_spirv_backend }}
 
+      - name: Report environment details
+        run: |
+          source ./scripts/capture-hw-details.sh --quiet
+          cat <<EOF | tee .env
+          TIMESTAMP=$(date '+%Y%m%d%H%M%S')
+          GITHUB_RUN_ID=$GITHUB_RUN_ID
+          GITHUB_RUN_NUMBER=$GITHUB_RUN_NUMBER
+          GITHUB_RUN_ATTEMPT=$GITHUB_RUN_ATTEMPT
+          PYTHON_VERSION=${{ inputs.python_version }}
+          PYTORCH_REPO=$PYTORCH_REPO
+          PYTORCH_COMMIT_ID=$PYTORCH_COMMIT_ID
+          PYTORCH_VERSION=$PYTORCH_VERSION
+          TRITON_REPO=$GITHUB_REPOSITORY
+          LIBIGC1_VERSION=$LIBIGC1_VERSION
+          LEVEL_ZERO_VERSION=$LEVEL_ZERO_VERSION
+          GPU_DEVICE=$GPU_DEVICE
+          AGAMA_VERSION=$AGAMA_VERSION
+          EOF
+
       - name: Create test-triton command line
         run: |
+          skiplist="$GITHUB_WORKSPACE/scripts/skiplist/default"
+
           if [[ -n "${{ inputs.skip_list }}" ]]; then
             skiplist="$GITHUB_WORKSPACE/scripts/skiplist/${{ inputs.skip_list }}"
           elif [[ -n "${{ inputs.driver_version }}" ]]; then
             skiplist="$GITHUB_WORKSPACE/scripts/skiplist/${{ inputs.driver_version }}"
-          else
-            skiplist="$GITHUB_WORKSPACE/scripts/skiplist/default"
           fi
 
           if [ -d "$skiplist" ]; then
             skiplist="--skip-list $skiplist"
           else
-            skiplist=
+            skiplist="--skip-list $GITHUB_WORKSPACE/scripts/skiplist/default"
           fi
 
           {
             echo SKIPLIST="$skiplist"
             echo TRITON_TEST_CMD="bash -v -x scripts/test-triton.sh --warning-reports --skip-pytorch-install --reports-dir $GITHUB_WORKSPACE/reports ${{ inputs.ignore_errors && '--ignore-errors' || '' }} $skiplist"
           } | tee -a $GITHUB_ENV
 
+      - name: Run Proton tests
+        if: ${{ inputs.driver_version == 'rolling' }}
+        run: |
+          cd third_party/proton/test
+          pytest test_api.py test_lib.py test_profile.py test_viewer.py -s -v
+          cd ..
+
       - name: Run unit tests
         run: |
           ${{ env.TRITON_TEST_CMD }} --unit
@@ -204,25 +231,6 @@ jobs:
           python scripts/pass_rate.py --reports reports --json ${{ env.SKIPLIST }} > pass_rate.json
           python scripts/pass_rate.py --reports reports --suite tutorials --json ${{ env.SKIPLIST }} > pass_rate_tutorials.json
 
-      - name: Report environment details
-        run: |
-          source ./scripts/capture-hw-details.sh --quiet
-          cat <<EOF | tee .env
-          TIMESTAMP=$(date '+%Y%m%d%H%M%S')
-          GITHUB_RUN_ID=$GITHUB_RUN_ID
-          GITHUB_RUN_NUMBER=$GITHUB_RUN_NUMBER
-          GITHUB_RUN_ATTEMPT=$GITHUB_RUN_ATTEMPT
-          PYTHON_VERSION=${{ inputs.python_version }}
-          PYTORCH_REPO=$PYTORCH_REPO
-          PYTORCH_COMMIT_ID=$PYTORCH_COMMIT_ID
-          PYTORCH_VERSION=$PYTORCH_VERSION
-          TRITON_REPO=$GITHUB_REPOSITORY
-          LIBIGC1_VERSION=$LIBIGC1_VERSION
-          LEVEL_ZERO_VERSION=$LEVEL_ZERO_VERSION
-          GPU_DEVICE=$GPU_DEVICE
-          AGAMA_VERSION=$AGAMA_VERSION
-          EOF
-
       - name: Upload pass rate report
         # upload reports only for the default branch
         if: github.ref_name == 'main'

.github/workflows/build-test-windows.yml

@@ -91,8 +91,8 @@ jobs:
           Invoke-BatchFile "C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Auxiliary\Build\vcvarsall.bat" x64
           cd ${{ env.NEW_WORKSPACE }}
           cd python
-          pip install -U wheel pybind11 cython cmake 'setuptools>=65.6.1'
-          pip install -v --no-build-isolation '.[build,tests,tutorials]'
+          pip install -U wheel pybind11 cython cmake
+          pip install -v '.[build,tests,tutorials]'
 
       - name: Triton version
         run: |

.github/workflows/build-windows.yml

@@ -58,8 +58,8 @@ jobs:
           Invoke-BatchFile "C:\Program Files\Microsoft Visual Studio\2022\Community\VC\Auxiliary\Build\vcvarsall.bat" x64
           cd ${{ env.NEW_WORKSPACE }}
           cd python
-          pip install -U wheel pybind11 cython cmake 'setuptools>=65.6.1'
-          pip install -v --no-build-isolation '.[build]'
+          pip install -U wheel pybind11 cython cmake
+          pip install -v '.[build]'
 
       - name: Clean
         if: ${{ always() }}

.github/workflows/create_release.yml

@@ -0,0 +1,76 @@
+name: Create Release
+
+on:
+  push:
+    branches:
+      - main
+      - release/*
+    tags:
+      # Final Release tags look like: v1.11.0
+      - v[0-9]+.[0-9]+.[0-9]+
+      # Release candidate tags look like: v1.11.0-rc1
+      - v[0-9]+.[0-9]+.[0-9]+-rc[0-9]+
+  release:
+    types: [published]
+  pull_request:
+    paths: [.github/workflows/create_release.yml]
+
+jobs:
+
+  release:
+    if: ${{ github.repository == 'triton-lang/triton' }}
+    name: Create Release
+    runs-on: ubuntu-latest
+    permissions:
+      contents: write
+    outputs:
+      release_name: "${{ steps.release_name.outputs.name }}"
+    steps:
+      - uses: actions/checkout@v4
+        with:
+          show-progress: false
+          submodules: 'recursive'
+          ref: ${{ github.event_name == 'pull_request' && github.event.pull_request.head.sha || github.sha }}
+      - name: Fake name for PRs
+        if: ${{ github.event_name == 'pull_request' }}
+        run: echo "PT_GITHUB_REF=refs/tags/pr-tag" >> "$GITHUB_ENV"
+      - name: Real name for non-PRs
+        if: ${{ github.event_name != 'pull_request' }}
+        run: echo "PT_GITHUB_REF=$GITHUB_REF" >> "$GITHUB_ENV"
+      - name: Set filenames
+        run: |
+          tag_or_branch="${PT_GITHUB_REF#refs/tags/}"
+          tag_or_branch="${tag_or_branch#refs/heads/}"
+          # replace directory separators with _ in branch name
+          tag_or_branch="${tag_or_branch//\//_}"
+          echo "RELEASE_NAME=triton-$tag_or_branch" >> "$GITHUB_ENV"
+          echo "RELEASE_FILE=triton-$tag_or_branch.tar.gz" >> "$GITHUB_ENV"
+      - name: Create source distribution
+        run: |
+            # Create new folder with specified name so extracting the archive yields that
+            rm -rf "/tmp/$RELEASE_NAME"
+            cp -r "$PWD" "/tmp/$RELEASE_NAME"
+            mv "/tmp/$RELEASE_NAME" .
+            # Cleanup
+            find "$RELEASE_NAME" -name '.git*' -exec rm -rv {} \; || true
+            # Create archive
+            tar -czf "$RELEASE_FILE" "$RELEASE_NAME"
+            echo "Created source archive $RELEASE_FILE with content: $(ls -a "$RELEASE_NAME")"
+      - name: Upload source distribution for release
+        if: ${{ github.event_name == 'release' }}
+        uses: softprops/action-gh-release@v2
+        with:
+          files: ${{env.RELEASE_FILE}}
+      - name: Upload source distribution to GHA artifacts for release tags
+        if: ${{ github.event_name == 'push' && startsWith(github.ref, 'refs/tags/v') && contains(github.ref, 'rc') }}
+        uses: actions/[email protected]
+        with:
+          name: ${{ env.RELEASE_FILE }}
+          path: ${{ env.RELEASE_FILE }}
+      - name: Set output
+        id: release_name
+        run: echo "name=release_name::${{ env.RELEASE_NAME }}.tar.gz" >> "${GITHUB_OUTPUT}"
+
+concurrency:
+  group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }}-${{ github.event_name }}
+  cancel-in-progress: true

.github/workflows/inductor-tests-reusable.yml

@@ -70,24 +70,8 @@ jobs:
 
       - name: Run inductor tests
         run: |
-          cd pytorch
-          pip install -r .ci/docker/requirements-ci.txt
-
           export PYTORCH_TESTING_DEVICE_ONLY_FOR="xpu"
-
-          test_cmd="python test/run_test.py --keep-going --include "
-          if [[ "${{ inputs.suite }}" = "all" ]]; then
-            for test in $(ls test/inductor | grep test);
-            do
-              test_cmd="${test_cmd} inductor/$test"
-            done
-          else
-            for test in ${{ inputs.suite }};
-            do
-              test_cmd="${test_cmd} $test"
-            done
-          fi
-          eval $test_cmd
+          bash scripts/test-pytorch.sh ${{ inputs.suite }}
 
       - name: Report environment details
         if: always()